From owner-freebsd-bugs@FreeBSD.ORG Mon Jul 1 12:10:00 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id A2772590 for ; Mon, 1 Jul 2013 12:10:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 884811800 for ; Mon, 1 Jul 2013 12:10:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r61CA0Z3001348 for ; Mon, 1 Jul 2013 12:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r61CA0o7001347; Mon, 1 Jul 2013 12:10:00 GMT (envelope-from gnats) Resent-Date: Mon, 1 Jul 2013 12:10:00 GMT Resent-Message-Id: <201307011210.r61CA0o7001347@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Fabian Keil Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id F18DD324 for ; Mon, 1 Jul 2013 12:00:54 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) by mx1.freebsd.org (Postfix) with ESMTP id C911D1786 for ; Mon, 1 Jul 2013 12:00:54 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r61C0shF062130 for ; Mon, 1 Jul 2013 12:00:54 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r61C0s5U062121; Mon, 1 Jul 2013 12:00:54 GMT (envelope-from nobody) Message-Id: <201307011200.r61C0s5U062121@oldred.freebsd.org> Date: Mon, 1 Jul 2013 12:00:54 GMT From: Fabian Keil To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: bin/180164: [patch][regression] swapon segfault after r252310 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jul 2013 12:10:00 -0000 >Number: 180164 >Category: bin >Synopsis: [patch][regression] swapon segfault after r252310 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jul 01 12:10:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Fabian Keil >Release: HEAD >Organization: >Environment: FreeBSD r500.local 10.0-CURRENT FreeBSD 10.0-CURRENT #586 r+49efc8c: Mon Jul 1 11:10:27 CEST 2013 fk@r500.local:/usr/obj/usr/src/sys/ZOEY amd64 >Description: The attached patch fixes a swapon segfault after r252310. BTW, I was surprised that the meaning of my fstab entry: /dev/ada0s1b.eli none swap sw 0 0 changed. It now enables authentication which reduces the available swap space. If this change is kept, I think it might be worth an UPDATING entry. >How-To-Repeat: fk@r500 ~ $sudo gdb76 --args swapon /dev/ada0s1b.eli GNU gdb (GDB) 7.6 [GDB v7.6 for FreeBSD] [...] (gdb) r Starting program: /sbin/swapon /dev/ada0s1b.eli Program received signal SIGSEGV, Segmentation fault. strlen (str=0x0) at /usr/src/lib/libc/string/strlen.c:100 100 va = (*lp - mask01); (gdb) where #0 strlen (str=0x0) at /usr/src/lib/libc/string/strlen.c:100 #1 0x0000000800ab1562 in strdup (str=0x0) at /usr/src/lib/libc/string/strdup.c:46 #2 0x0000000000402351 in swap_on_off_geli (mntops=0x0, name=0x7fffffffdb6d "/dev/ada0s1b.eli", doingall=) at /usr/src/sbin/swapon/swapon.c:339 #3 swap_on_off (name=0x7fffffffdb6d "/dev/ada0s1b.eli", doingall=0, mntops=0x0) at /usr/src/sbin/swapon/swapon.c:242 #4 0x000000000040205c in main (argc=, argv=) at /usr/src/sbin/swapon/swapon.c:200 >Fix: Patch attached with submission follows: >From 4cf8c315df4f1c5761f8a90274ba551ec1f1fa36 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Mon, 1 Jul 2013 13:27:44 +0200 Subject: [PATCH] Fix segmentation fault when swap_on_off_geli() is called without mount options --- sbin/swapon/swapon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbin/swapon/swapon.c b/sbin/swapon/swapon.c index cf9b979..8bcfc55 100644 --- a/sbin/swapon/swapon.c +++ b/sbin/swapon/swapon.c @@ -336,7 +336,7 @@ swap_on_off_geli(char *name, char *mntops, int doingall) } *p = '\0'; - ops = strdup(mntops); + ops = strdup(mntops != NULL ? mntops : ""); /* Default parameters for geli(8). */ aalgo = aalgo_default; -- 1.8.2.2 >Release-Note: >Audit-Trail: >Unformatted: