From owner-freebsd-ports@FreeBSD.ORG Wed Jun 23 19:43:26 2010 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5EC73106566C for ; Wed, 23 Jun 2010 19:43:26 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 03FC68FC14 for ; Wed, 23 Jun 2010 19:43:25 +0000 (UTC) Received: (qmail 29072 invoked by uid 399); 23 Jun 2010 19:43:25 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 23 Jun 2010 19:43:25 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4C2263DC.7050209@FreeBSD.org> Date: Wed, 23 Jun 2010 12:43:24 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.10) Gecko/20100621 Thunderbird/3.0.5 MIME-Version: 1.0 To: "Philip M. Gollucci" References: <20100623144021.GC280@atarininja.org> <4C221E32.60400@p6m7g8.com> <4C225D42.4040603@FreeBSD.org> <4C225E4A.8010607@p6m7g8.com> In-Reply-To: <4C225E4A.8010607@p6m7g8.com> X-Enigmail-Version: 1.0.1 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: David DEMELIER , freebsd-ports@FreeBSD.org Subject: Re: New pkg-message[.in] guideline idea X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2010 19:43:26 -0000 On 06/23/10 12:19, Philip M. Gollucci wrote: > On 06/23/10 19:15, Doug Barton wrote: >>> I think we need 2 things: >>>> >>>> 1) All pkg-message whether .in or not go >>>> through the 'sed' that SUB_LIST/PLIST_SUB do. >> I like this idea better than forcing them all to be in /files, and I >> can't see any reason not to do it. > The other benefit is you can carry over the PLIST logic with @comment to > conditionalize lines in the message and thus eliminate all that crap > from Makefiles. Yes, simpler is better. :) >>>> 2) You collect them in to /var/db/pkg and loop >>>> and display at end. >>>> >>>> As a consequence all formatting should be removed from the individual >>>> pkg-message[.in] files and added in #2. >> I'm ambivalent about this. My first thought was that the formatting >> should happen in step #1. What portmaster does is build each port one at >> a time, and it makes a note if a port has a pkg-message. Then it does >> what you suggest in #2 by cat'ing them all to $PAGER. However, thinking >> more about it I could see how not doing the formatting until step 2 >> could work, so however it turns out to be "easiest" should be fine. > I believe we are agreeing. I didn't say anything about > portmaster/portupgrade. The pkg/make infrastructure needs to do it at > the end so that it works via pkg_add, make, or portmaster et al. Yes, we are agreeing. I was simply adding my perspective as a tool author to your proposal. I also agree that the ports infrastructure itself should be as robust as possible, and include features like this whenever it can. hth, Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/