From owner-svn-src-head@freebsd.org Tue Nov 17 17:29:52 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4116046A218 for ; Tue, 17 Nov 2020 17:29:52 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CbCcc1GcHz3Bsb for ; Tue, 17 Nov 2020 17:29:51 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f48.google.com with SMTP id w24so3995192wmi.0 for ; Tue, 17 Nov 2020 09:29:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=jX6kARcgylLein7oAi3Wg8AfpwGEqF3HvfiPIcvXkxs=; b=KN5XLNMRBsAeFul9ZvcA4s9LRpQ0KGnKI7Id+jew+TefAfkqBE7cLMrTPDdvoePxBC nHAuJBaXhj3TrWNKZNHYkVWYi+B5xps2LvYarV7z6AtPryCmrVnTMRpf+Qm28yFr9sa8 i5DiJjJqrGEqiINhzQBdZ0n6iU9lDccPZRsHTPuYf9u5QW0bRxuoYjqYrFn8P58kehrY 5ZGTK+ulWqqi9gb0OBeLoucLXIbjMqqvnPH/Xqy0PM8N97or2MOUTVGQfI5q8UbMD+Bq 9cGS/7kL7hV9bzwUWoWBlMH9uKG+n8+GHXeCx00+wZFhLSIJcM0PB/06DxPKRR93TMiu GjHg== X-Gm-Message-State: AOAM530knFfAMHRpu30ZqY53Jt+Byd2T+9DdU5bwMn3jl7VsQrd6WwmX P/38MRcVTh3DduwjX0/cOsqB0g== X-Google-Smtp-Source: ABdhPJyB6C7X+eW5ow9Huquyh1OUagRi0JPSeVqwp9xVbP9l2ImQJvBAseyzYhTS6XyK/Wp30tEemA== X-Received: by 2002:a1c:398a:: with SMTP id g132mr154761wma.51.1605634190533; Tue, 17 Nov 2020 09:29:50 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id z189sm4466129wme.23.2020.11.17.09.29.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Nov 2020 09:29:49 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: svn commit: r367771 - head/sbin/nvmecontrol From: Jessica Clarke In-Reply-To: <202011171712.0AHHCS3V017391@repo.freebsd.org> Date: Tue, 17 Nov 2020 17:29:49 +0000 Cc: src-committers , svn-src-all , svn-src-head Content-Transfer-Encoding: 7bit Message-Id: <5C44DBA6-CBA2-49E9-8AFC-45C62664D2FD@freebsd.org> References: <202011171712.0AHHCS3V017391@repo.freebsd.org> To: Adrian Chadd X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4CbCcc1GcHz3Bsb X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2020 17:29:52 -0000 On 17 Nov 2020, at 17:12, Adrian Chadd wrote: > @@ -175,8 +176,7 @@ update_firmware(int fd, uint8_t *payload, int32_t payl > errx(EX_OSERR, "unable to malloc %zd bytes", (size_t)max_xfer_size); > > while (resid > 0) { > - size = (resid >= (int32_t)max_xfer_size) ? > - max_xfer_size : resid; > + size = (resid >= max_xfer_size) ? max_xfer_size : resid; MIN from the already-included sys/param.h? (Otherwise: you have an extra space after ?) Jess