From owner-freebsd-net Mon Aug 19 12:40:27 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CCB8937B401; Mon, 19 Aug 2002 12:40:24 -0700 (PDT) Received: from cheer.mahoroba.org (flets19-007.kamome.or.jp [218.45.19.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B89343E42; Mon, 19 Aug 2002 12:40:22 -0700 (PDT) (envelope-from ume@mahoroba.org) Received: from mille.mahoroba.org (IDENT:CZKdMX+uSngLpAXa7UQmNHATgRwr7c5i6FIU2TDw/103u0azjLYZMHVdoVACnLkU@mille.mahoroba.org [IPv6:2001:200:301:0:202:2dff:fe0a:6bee]) (user=ume mech=CRAM-MD5 bits=0) by cheer.mahoroba.org (8.12.5/8.12.5) with ESMTP/inet6 id g7JJeJbQ093836 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Tue, 20 Aug 2002 04:40:19 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Tue, 20 Aug 2002 04:40:19 +0900 Message-ID: From: Hajimu UMEMOTO To: Juli Mallett Cc: net@FreeBSD.org Subject: Re: log_in_vain does not format IPv6 addrs properly for how they are used... In-Reply-To: <20020819115048.A47313@FreeBSD.org> References: <20020819112408.A45895@FreeBSD.org> User-Agent: xcite1.38> Wanderlust/2.9.14 (Unchained Melody) SEMI/1.14.4 (Hosorogi) FLIM/1.14.3 (=?ISO-8859-4?Q?Unebigory=F2mae?=) APEL/10.3 Emacs/21.2 (i386--freebsd) MULE/5.0 (=?ISO-2022-JP?B?GyRCOC1MWhsoQg==?=) X-Operating-System: FreeBSD 4.6-STABLE MIME-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by AMaViS-perl11-milter (http://amavis.org/) Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Hi, >>>>> On Mon, 19 Aug 2002 11:50:49 -0700 >>>>> Juli Mallett said: jmallett> Yeah, but it's still tough for readability, all those [0-9A-F:]+ Yes, actually. jmallett> Okay, thanks. What about with a change to netinet6/udp6_usrreq.c to simply jmallett> log() with brackets, like: jmallett> - "Connection attempt to UDP %s:%d from %s:%d\n", jmallett> + "Connection attempt to UDP [%s]:%d from [%s]:%d\n", jmallett> If that's an OK change to make, too, then I will commit these changes. Though netinet6/udp6_usrreq.c is in common part of KAME repo., here is still FreeBSD specific part, and enclosed by #ifdef __FreeBSD__ ... #endif in KAME repo. So, please go ahead. Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@bisd.hitachi.co.jp ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message