From owner-cvs-all  Mon Feb 25 21:51:10 2002
Delivered-To: cvs-all@freebsd.org
Received: from espresso.q9media.com (espresso.q9media.com [216.254.138.122])
	by hub.freebsd.org (Postfix) with ESMTP
	id 910AA37B405; Mon, 25 Feb 2002 21:51:04 -0800 (PST)
Received: (from mike@localhost)
	by espresso.q9media.com (8.11.6/8.11.6) id g1Q5k2S83008;
	Tue, 26 Feb 2002 00:46:02 -0500 (EST)
	(envelope-from mike)
Date: Tue, 26 Feb 2002 00:46:02 -0500
From: Mike Barcroft <mike@FreeBSD.org>
To: Maxim Sobolev <sobomax@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/gen getgrent.3 src/include grp.h
Message-ID: <20020226004602.G31007@espresso.q9media.com>
References: <200202251720.g1PHKf699380@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200202251720.g1PHKf699380@freefall.freebsd.org>; from sobomax@FreeBSD.org on Mon, Feb 25, 2002 at 09:20:41AM -0800
Organization: The FreeBSD Project
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Maxim Sobolev <sobomax@FreeBSD.org> writes:
> sobomax     2002/02/25 09:20:41 PST
> 
>   Modified files:
>     lib/libc/gen         getgrent.3 
>     include              grp.h 
>   Log:
>   Per POSIX <grp.h> doesn't require <sys/types.h>.
>   
>   Submitted by:   ache
>   
>   Revision  Changes    Path
>   1.8       +3 -2      src/include/grp.h
>   1.19      +0 -1      src/lib/libc/gen/getgrent.3

This is incorrect.  Please back out the change to <grp.h> which
includes <sys/types.h>.  When POSIX says "The gid_t type shall be
defined as described in <sys/types.h>", that does *NOT* mean include
<sys/types.h>.

I will provide a correct solution after you have backed this out.

In future, please have all header related changes reviewed by
-standards.

Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message