From owner-svn-ports-all@FreeBSD.ORG Mon Dec 3 14:13:05 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1C9BC445; Mon, 3 Dec 2012 14:13:05 +0000 (UTC) (envelope-from glarkin@FreeBSD.org) Received: from mail1.sourcehosting.net (mail1.sourcehosting.net [74.205.51.45]) by mx1.freebsd.org (Postfix) with ESMTP id DC6858FC08; Mon, 3 Dec 2012 14:13:04 +0000 (UTC) Received: from 24-181-237-39.dhcp.oxfr.ma.charter.com ([24.181.237.39] helo=Gregory-Larkins-iMac.local) by mail1.sourcehosting.net with esmtp (Exim 4.73 (FreeBSD)) (envelope-from ) id 1TfWlM-000CF6-Gn; Mon, 03 Dec 2012 09:12:58 -0500 Received: from Gregory-Larkins-iMac.local (localhost [127.0.0.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by Gregory-Larkins-iMac.local (Postfix) with ESMTPS id DEAEB181F3A1; Mon, 3 Dec 2012 09:12:47 -0500 (EST) Message-ID: <50BCB35F.8030606@FreeBSD.org> Date: Mon, 03 Dec 2012 09:12:47 -0500 From: Greg Larkin Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Frederic Culot References: <201212031348.qB3DmPQl042147@svn.freebsd.org> In-Reply-To: <201212031348.qB3DmPQl042147@svn.freebsd.org> X-Enigmail-Version: 1.4.6 X-SA-Exim-Connect-IP: 24.181.237.39 X-SA-Exim-Mail-From: glarkin@FreeBSD.org X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail1.sourcehosting.net X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00, RCVD_IN_SORBS_DUL,RDNS_DYNAMIC,TVD_RCVD_IP autolearn=no version=3.3.1 Subject: Re: svn commit: r308151 - head/devel/p5-Exception-Class Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Version: 4.2 X-SA-Exim-Scanned: Yes (on mail1.sourcehosting.net) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: glarkin@FreeBSD.org List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Dec 2012 14:13:05 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/3/12 8:48 AM, Frederic Culot wrote: > Author: culot Date: Mon Dec 3 13:48:25 2012 New Revision: 308151 > URL: http://svnweb.freebsd.org/changeset/ports/308151 > > Log: - Shorten COMMENT description > > Suggested by: danfe@ Feature safe: yes > > Modified: head/devel/p5-Exception-Class/Makefile > > Modified: head/devel/p5-Exception-Class/Makefile > ============================================================================== > > - --- head/devel/p5-Exception-Class/Makefile Mon Dec 3 13:33:29 2012 (r308150) > +++ head/devel/p5-Exception-Class/Makefile Mon Dec 3 13:48:25 2012 > (r308151) @@ -7,7 +7,7 @@ MASTER_SITES= CPAN PKGNAMEPREFIX= p5- > > MAINTAINER= perl@FreeBSD.org -COMMENT= Module that allows you to > declare real exception classes in Perl +COMMENT= Module that allows > to declare real exception classes in Perl > > LICENSE= ART20 > > The COMMENT is no longer well-formed English grammar. I suggest reverting the change or perhaps rewriting it to something more concise, such as "Module that declares real exception classes in Perl" or "Real exception classes in Perl". How much port description rewriting should be done beyond the suggestions in the Porter's Handbook (http://www.freebsd.org/doc/en/books/porters-handbook/book.html#makefile-comment)? I don't have a problem with the original comment, including the word "you", and in this case it seems more of a PITA to rewrite it to omit that word and result in correct English. Thoughts? Regards, Greg - -- Greg Larkin http://www.FreeBSD.org/ - The Power To Serve http://www.sourcehosting.net/ - Ready. Set. Code. http://twitter.com/cpucycle/ - Follow you, follow me -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (Darwin) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iEYEARECAAYFAlC8s18ACgkQ0sRouByUApB11ACcCN9iw6GiymrWNxVRk5KmAd+2 j24AnROtu9tXeu4eIK+zys/gfH4KpD5x =Jq5H -----END PGP SIGNATURE-----