Date: Fri, 07 Jan 2011 15:28:44 +0300 From: Anonymous <swell.k@gmail.com> To: Anton Shterenlikht <mexas@bristol.ac.uk> Cc: riggs@rrr.de, freebsd-ports@freebsd.org, Eygene Ryabinkin <rea@freebsd.org> Subject: Re: mplayer options patch Message-ID: <8662u0hp8j.fsf@gmail.com> In-Reply-To: <20110107120900.GA70442@mech-cluster241.men.bris.ac.uk> (Anton Shterenlikht's message of "Fri, 7 Jan 2011 12:09:00 %2B0000") References: <20110107095816.GA64948@mech-cluster241.men.bris.ac.uk> <MKws6xL2clvIhh8rR9KC/WtQ8GE@QsmfhJNucgI88DfvPJdT1/nyboE> <86lj2xhrfi.fsf@gmail.com> <20110107114923.GA70063@mech-cluster241.men.bris.ac.uk> <86wrmghqjc.fsf@gmail.com> <20110107120900.GA70442@mech-cluster241.men.bris.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
Anton Shterenlikht <mexas@bristol.ac.uk> writes:
> On Fri, Jan 07, 2011 at 03:00:39PM +0300, Anonymous wrote:
>> Anton Shterenlikht <mexas@bristol.ac.uk> writes:
>>
>> >> $ make config
>> >> "Makefile", line 16: Malformed conditional (${ARCH} == "i386" || ${ARCH} == "amd64" || ${ARCH} == "powerpc")
>> >> "Makefile", line 18: if-less else
>> >> "Makefile", line 20: if-less endif
>> >> make: fatal errors encountered -- cannot continue
>> >
>> > I put Eygene's snippet after .include <bsd.port.pre.mk>,
>> > see my previous post. It seems to work.
>>
>> bsd.port.pre.mk starts after OPTIONS were already parsed.
>> Try to check
>>
>> $ make rmconfig
>> $ make -V WITH_RTCPU ARCH=sparc64
>> true
>
> # make rmconfig
> ===> Removing user-configured options for mplayer-1.0.r20101106
> rmdir: /var/db/ports/mplayer: Directory not empty
> *** Error code 1 (ignored)
> # make -V WITH_RTCPU ARCH=sparc64
>
> # make -V WITH_RTCPU ARCH=ia64
>
> #
My bad, I forgot to remove RTCPU when added the ifdef.
$ make -V WITH_RTCPU ARCH=sparc64
$ make -V WITHOUT_RTCPU ARCH=sparc64
$ make -V CONFIGURE_ARGS ARCH=sparc64 | fgrep run
... --enable-runtime-cpudetection ... ${_LATE_CONFIGURE_ARGS}
It's not only for sparc64, there is no WITH/WITHOUT_RTPCU for i386.
But the configure option still works
.if !defined(WITHOUT_RTCPU)
CONFIGURE_ARGS+=--enable-runtime-cpudetection
.endif
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8662u0hp8j.fsf>