From owner-freebsd-ppc@freebsd.org Tue Jun 30 04:05:26 2015 Return-Path: Delivered-To: freebsd-ppc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB0CF990FAA; Tue, 30 Jun 2015 04:05:26 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-ig0-x232.google.com (mail-ig0-x232.google.com [IPv6:2607:f8b0:4001:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9DB1412D7; Tue, 30 Jun 2015 04:05:26 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by igblr2 with SMTP id lr2so66681556igb.0; Mon, 29 Jun 2015 21:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=tHXT1L2sq+WjzVC5B6zm1/+OQQygUYkwdZtCiE1YIwU=; b=L/KVyFajbSg8Ch06rTzZiQJCrrnTy0uG2SIbD39z35oW4eK0sSVIF+Ejui9TgmWqKi gzg0E+IRZs14uVRmXUIKg+0ivkNAzQDnvpXNNXT/XfJIyagbnIQaOesP6o8ZtuXLYoF+ TxLPasrCFdqggYjDaJjYU1TC6V19woZmZATA6O8K/2SWGkbDK3txfH1XfwuniPztfovf mU7A/PleH8+TpALBmKM2oxtqyWGGkIKXliXBcnM5fnx6t/Rc5ZNAIJJg7I/DdnRsNH9n CckzSxrrH/UGm5r9e9Jwpm7rRHQaVDPIRQ0EV+DBqPYoZoMFCJWlJeyBpENevDPBuE40 V96A== MIME-Version: 1.0 X-Received: by 10.42.226.8 with SMTP id iu8mr22848417icb.17.1435637126029; Mon, 29 Jun 2015 21:05:26 -0700 (PDT) Sender: chmeeedalf@gmail.com Received: by 10.36.69.80 with HTTP; Mon, 29 Jun 2015 21:05:25 -0700 (PDT) In-Reply-To: References: <8C09575A-B885-4F41-BFF8-46FEC028E755@gmail.com> <20150628193222.GP2080@kib.kiev.ua> <559059ED.80104@fgznet.ch> <20150629053248.GQ2080@kib.kiev.ua> Date: Mon, 29 Jun 2015 21:05:25 -0700 X-Google-Sender-Auth: GM0n6Je48Ut9lKo1LFHMbgW9tRw Message-ID: Subject: Re: powerpc and powerpc64 builds broken From: Justin Hibbits To: Konstantin Belousov Cc: Andreas Tobler , Garrett Cooper , FreeBSD Current , FreeBSD PowerPC ML Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jun 2015 04:05:26 -0000 On Mon, Jun 29, 2015 at 4:58 PM, Justin Hibbits wrote: > On Sun, Jun 28, 2015 at 10:32 PM, Konstantin Belousov > wrote: >> On Sun, Jun 28, 2015 at 10:32:45PM +0200, Andreas Tobler wrote: >>> On 28.06.15 21:32, Konstantin Belousov wrote: >>> > On Sun, Jun 28, 2015 at 12:09:25PM -0700, Justin Hibbits wrote: >>> >> On Sun, Jun 28, 2015 at 11:36 AM, Garrett Cooper wrote: >>> >>> >>> >>>> On Jun 28, 2015, at 10:48, Justin Hibbits wrote: >>> >>>> >>> >>>> Both powerpc and powerpc64 builds are broken in the same way, in >>> >>>> usr.bin/mkesdb. It was working correctly as of just before BSDCan, I >>> >>>> successfully built world and kernel on June 6. >>> >>>> >>> >>>> The error seen at this point is: >>> >>>> >>> >>>> cc -O2 -pipe -I/home/chmeee/freebsd/head/usr.bin/mkesdb >>> >>>> -I/home/chmeee/freebsd/head/usr.bin/mkesdb/../mkesdb >>> >>>> -I/home/chmeee/freebsd/head/usr.bin/mkesdb/../../lib/libc/iconv >>> >>>> -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall >>> >>>> -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes >>> >>>> -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual >>> >>>> -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align >>> >>>> -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls >>> >>>> -Wold-style-definition -Wno-pointer-sign >>> >>>> -L/home/chmeee/world/zhabar/home/chmeee/freebsd/head/usr.bin/mkesdb/../../lib/libc >>> >>>> -o mkesdb lex.o yacc.o >>> >>>> /home/chmeee/world/zhabar/home/chmeee/freebsd/head/tmp/usr/bin/ld: >>> >>>> undefined reference to symbol `_end' (try adding -lc) >>> >>>> /home/chmeee/world/zhabar/home/chmeee/freebsd/head/tmp/lib/libc.so.7: >>> >>>> could not read symbols: Bad value >>> >>>> >>> >>>> I've seen this both locally on my G5, and on the Power8 in the FreeBSD cluster. >>> >>> >>> >>> - What does file say when you run it on libc.so.7? >>> >> >>> >> /usr/obj/usr/src/lib/libc/libc.so.7: ELF 64-bit MSB shared object, >>> >> 64-bit PowerPC or cisco 7500, version 1 (FreeBSD), dynamically linked, >>> >> not stripped >>> > I think a libc linker could try for that command line lives in >>> > /home/chmeee/world/zhabar/home/chmeee/freebsd/head/lib/libc/libc.so >>> > or in >>> > /home/chmeee/world/zhabar/home/chmeee/freebsd/head/tmp/lib/libc.so >>> > >>> > But, the reason for your troubles seems to come from the >>> > usr.bin/mkesdb/Makefile. Why does it explicitely adds LDFLAGS to point >>> > to objdir/.../libc, I have no idea. >>> >>> >>> Neither me. >>> >>> Here with this mods it compiles: >>> >>> Either: >>> >>> --- Makefile (revision 284911) >>> +++ Makefile (working copy) >>> @@ -3,7 +3,7 @@ >>> .PATH: ${.CURDIR}/../../lib/libc/iconv >>> >>> PROG= mkesdb >>> -LDFLAGS+= -L${.OBJDIR}/../../lib/libc >>> +LDFLAGS+= -L${.OBJDIR}/../../lib/libc/libc >>> >>> NO_WMISSING_VARIABLE_DECLARATIONS= >>> >>> >>> Or: >>> >>> Index: Makefile >>> =================================================================== >>> --- Makefile (revision 284911) >>> +++ Makefile (working copy) >>> @@ -3,7 +3,7 @@ >>> .PATH: ${.CURDIR}/../../lib/libc/iconv >>> >>> PROG= mkesdb >>> -LDFLAGS+= -L${.OBJDIR}/../../lib/libc >>> +LDFLAGS+= -L${.CURDIR}/../../lib/libc >>> >>> NO_WMISSING_VARIABLE_DECLARATIONS= >> >> No, I mean that LDFLAGS explicitely listing supposed location for libc >> is wrong, too much wrong. If mkesd is special, it might need to become >> a bootstrap tool. But the hackery above is too fragile and it is surprising >> that it went unnoticed for such long time (after the citrus enablement). > > Would anyone object to me simply removing that line? This fixes the > build on powerpc64, and I highly doubt it would impact any other > build. > > - Justin A universe build on the cluster passed, I'm nuking it. - Justin