From owner-cvs-src-old@FreeBSD.ORG Thu Feb 26 21:34:02 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 694C4106566B for ; Thu, 26 Feb 2009 21:34:02 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 55DCE8FC1A for ; Thu, 26 Feb 2009 21:34:02 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n1QLY2G1054217 for ; Thu, 26 Feb 2009 21:34:02 GMT (envelope-from mav@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n1QLY2xd054216 for cvs-src-old@freebsd.org; Thu, 26 Feb 2009 21:34:02 GMT (envelope-from mav@repoman.freebsd.org) Message-Id: <200902262134.n1QLY2xd054216@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to mav@repoman.freebsd.org using -f From: Alexander Motin Date: Thu, 26 Feb 2009 21:33:48 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-queue.c ata-raid.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2009 21:34:02 -0000 mav 2009-02-26 21:33:48 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.c ata-all.h ata-queue.c ata-raid.c Log: SVN rev 189091 on 2009-02-26 21:33:48Z by mav Remove direct ata_completed() call options from ata_finish(), except for the kernel dumping case. ata_completed() may initiate ata_reinit() on error, that may lead to drives attach or detach. Attach and detach are sending requests to drives and sleep waiting for results. But ata_finish() can be called directly from interrupt handler where sleeping is prohibited, so we must break this chain somewhere. This place seems to fit best. Revision Changes Path 1.300 +1 -1 src/sys/dev/ata/ata-all.c 1.140 +0 -1 src/sys/dev/ata/ata-all.h 1.80 +1 -7 src/sys/dev/ata/ata-queue.c 1.132 +8 -8 src/sys/dev/ata/ata-raid.c