From owner-freebsd-current@freebsd.org Tue Aug 21 14:16:19 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 54D9F1073EAC for ; Tue, 21 Aug 2018 14:16:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x235.google.com (mail-it0-x235.google.com [IPv6:2607:f8b0:4001:c0b::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DAD2085A0F for ; Tue, 21 Aug 2018 14:16:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x235.google.com with SMTP id g141-v6so4243270ita.4 for ; Tue, 21 Aug 2018 07:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=q/gPgnNaEBvSt/wcYHV0vDcc+81MouwEAPPvFMTJoGw=; b=A4Myi/3YYKK/tQJPAsANH6Gqp4SJbgZycKwVSJqCQoJtIbM8HJjg7vAXXhowPExXlw LW0gZXOfyRDUwQKXDEYVU9DX/+c+9h5gQJDP7M/z7h0yXNCzdH20wPLVt1WZpK0UHs4I Upy1Hie2dzXOxnws5f0m4+EkoBTeih04k3576iEqdboLlWN5Y+HwkYlKnimfoHMWH62a yIx1Om7ZOa4QUwy5iD2mS6xkDf7yfK5XkhM1LF0fDG6uFrs9DWmwon1nrv74i6FWmOQr xn64UZm9KYL2qqA8+eQFfC+GBm64t/PRYRxtEDq+c3HZi4BGHK3vMjt/B0/is5Iced+Q XgiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=q/gPgnNaEBvSt/wcYHV0vDcc+81MouwEAPPvFMTJoGw=; b=J6zILzr2e/uQlsjjiK6STLmEx1kDha48DRkfDDR2VyOHQ+Hlwsjezyk1PeeOuN+nT1 045x+ZPOLfh2G+gygulF8h2ASd8ZTuQFrBvOzszTbQTLrZV4IwNrHjueMLXtTzXrICg0 hKgLsx2xFguu5PmBsi19pvH8u4YLUBgL5fohe+ijHoCpBiyqMQ78nrbXf7JV/NxAB6Ua TJhDr7cRD3yW/qG5KJdv1vO3WqVvCiri+EN2jhnopcU4j2FvlAs0kfIZZF/RCgLZho9v B5z/21EVn567KFSE0VuGNupj3+xc1ZLUwPHOSF7Cpij8hvnPx4dJXGJCnx0EzE+6ydMA NzOQ== X-Gm-Message-State: AOUpUlErMIzoEB8T4zPKuRoLTLm9reCUK4rMXQd3V2i/Y6cT9ST812DG 5Rlj6JdI+wA16kdN0o8hS+rv+dzf4stYPeEld9p0LQ== X-Google-Smtp-Source: AA+uWPwohbWG54IPdteM73TGd2uHmUa6OhNsFqd3L5SG+Z6d53zoXI6NK3Gfpyd0+2KNHRpNtOPw69rV0O73KTlktyQ= X-Received: by 2002:a24:83c6:: with SMTP id d189-v6mr16934071ite.75.1534860978181; Tue, 21 Aug 2018 07:16:18 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:2806:0:0:0:0:0 with HTTP; Tue, 21 Aug 2018 07:16:17 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <20180820212448.571e1060@thor.intern.walstatt.dynvpn.de> <20180820220103.3ac8a3ac@thor.intern.walstatt.dynvpn.de> <6040ed15-143f-9a6d-8f37-b25a7e2d2036@FreeBSD.org> From: Warner Losh Date: Tue, 21 Aug 2018 08:16:17 -0600 X-Google-Sender-Auth: ObxMXvTmPi4TDUqR_RohOCE2R0I Message-ID: Subject: Re: buildworld failure: Do not include ${SRCTOP}/sys when building bootstrap tools To: Alexander Richardson Cc: John Baldwin , "O. Hartmann" , FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 14:16:19 -0000 There's a half a dozen special targets, however. clean comes to mind... However, this test is needlessly restrictive: .if !empty(CFLAGS:M*${SRCTOP}/sys*:N*${SRCTOP}/sys/cddl/compat*:N*${SRCTOP}/sys/crypto*) since it matches CFLAGS+=-I${SRCTOP}/sys/sys/disk which is totally legit. It's designed to be legit everywhere for building on Linux... .if !empty(CFLAGS:M*${SRCTOP}/sys:N*${SRCTOP}/sys/cddl/compat:N*${SRCTOP}/sys/crypto) would be a better test, imho. Warner On Tue, Aug 21, 2018 at 8:11 AM, Alexander Richardson < arichardson@freebsd.org> wrote: > In my testing 338129 fixed the issue. Seems like the problem is that > bsd.crunchgen.mk iterates over all directories to do a make obj when > it does the bootstrap-tools phase. > On Tue, 21 Aug 2018 at 14:49, Warner Losh wrote: > > > > > > > > On Tue, Aug 21, 2018 at 12:38 AM, John Baldwin wrote: > >> > >> On 8/20/18 9:00 PM, O. Hartmann wrote: > >> > -----BEGIN PGP SIGNED MESSAGE----- > >> > Hash: SHA512 > >> > > >> > Am Mon, 20 Aug 2018 21:24:21 +0200 > >> > "O. Hartmann" schrieb: > >> > > >> >> -----BEGIN PGP SIGNED MESSAGE----- > >> >> Hash: SHA512 > >> >> > >> >> Building NanoBSD world on CURRENT r338113 fails due to: > >> >> > >> >> [...] > >> >> cd /pool/sources/CURRENT/src/rescue/rescue/../../sbin/gbde && > MK_TESTS=no > >> >> UPDATE_DEPENDFILE=no _RECURSING_CRUNCH=1 > >> >> MAKEOBJDIRPREFIX=/pool/nanobsd/amd64/ALERICH_amd64/ > pool/sources/CURRENT/src/amd64.amd64/rescue/rescue > >> >> make MK_AUTO_OBJ=no DIRPRFX=rescue/rescue/gbde/ -DRESCUE > CRUNCH_CFLAGS=-DRESCUE > >> >> MK_AUTO_OBJ=no obj make[5]: "/pool/sources/CURRENT/src/ > tools/build/mk/Makefile.boot" > >> >> line 18: Do not include ${SRCTOP}/sys when building bootstrap > tools. Copy the header to > >> >> ${WORLDTMP}/legacy in tools/build/Makefile instead. Error was > caused by Makefile > >> >> in /pool/sources/CURRENT/src/sbin/gbde *** [obj_crunchdir_gbde] > Error code 1 > >> >> > >> >> make[4]: stopped in /pool/sources/CURRENT/src/rescue/rescue > >> >> [...] > >> >> > >> >> > >> >> This problem occured during today's source updates since I was able > to build the NanoBSD > >> >> image I intend to build yesterday ~ r338060. > >> >> > >> >> What is going wrong? > >> > > >> > It seems the problem has been introduced after r338095, since r338095 > builds ok, while > >> > r338096 doesn't. > >> > >> 338096 added this check to catch a kind of error in our Makefiles. > Alex (cc'd) can > >> help with figuring out what the error is. > > > > > > Except we're not building anything, we're making obj in rescue... It > looks like a false positive... > > > > Warner >