From nobody Sat Mar 30 16:31:42 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V6N8L5tBnz5FyJR; Sat, 30 Mar 2024 16:31:46 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V6N8L3XFMz4KT2; Sat, 30 Mar 2024 16:31:46 +0000 (UTC) (envelope-from tijl@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711816306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sNKFuanuzz+5rszquzNWMBQJbcyGawHGKdzJw9e4VZc=; b=KV70jLf9ku2Kv/vnKb9xHGosvk2QTgk8IB35UWNnEOvuVX8JT9OMf7v33iOubTk3FOi9zy zmeihlGW9ApELpi/MpjtFRQxbfP3lGHqE2ij5S2zri08NL6Hqfd1rOs85hZjdiXWx3jtDm T9M/hyKx+uA3uiJyn7gRH+kRx5IGPN0/8a1C6uttJEJlw9K9dimNB5xvwQCH0lIq0NymdD UnyrdD7LZgpD3otTmvLHB727GYHgO1GErE+hyTSj7hNTIKa+gnzWtSbSBMJ6MPC3aeR9HR 1Q6tj6DeY8/scPqxxFnVh7omSYfUFZbOrP2Lp8WhlwXReXcFuBDbyIUFs3x6QQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711816306; a=rsa-sha256; cv=none; b=DUgnpxN1sSVOYWPIdWPswIPCvJBav5R9+CPEe2j2treOPKg0BJiwJJ2jHf1/TlHXsr1XA/ ks012tCwHKKaxTEdTUAmejGu87MUeg6ai8bnbX7Wha2jAl+JAilTymCd39CNrCCBm9oZqq FtFr166e70ecHmoEjABUECvpbXXD0mYCTEDxmV4Gw7ZuSw0kqnKg2ypbxmsV5WGmwPnYiX +fHk0hTvpsusId/qi+UVGvw5R7hvdTTWcTNowHn3V4cQNTLQzq7Z6Noixmu5rTHSOXiGAW baBFGCfiw6G45D2yQWRKYgdPAA9V1s0vr6eCERFxw0X0Zv81Ge3iAqXCRR2nxA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711816306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sNKFuanuzz+5rszquzNWMBQJbcyGawHGKdzJw9e4VZc=; b=d09wgQI3KRDi/DK0zEsz6ACWEGlKPgkQV0tEG2KP/FC15RENY2/772wIDCkCfZNKPhv8uq IsnhbfAsMnzxqyZWr79u5JNqyPlW4WuHS+4Olf11b7kn2+fEZeInqHia2aKIyej/yteYxM 6EILtdo8Qu4H5rq9POTEGO2R8B5W0PjboY2Krv3POmi7iGHLoSlSr9307LUc6up3RzkEg+ LCA2YYEBr0Qlw+LR8tP+7SVDcRkwRWIrwgR2oEkTRzzcq1aqIN/1J1XGGzHEh+xoTWrHz2 9nUjzaaLvvFf1kAaEdfOJXZhQlVs/j4RgUrUVxw06PlAU20U/PoqsENFBXoKWw== Received: from hal.tijl.coosemans.org (unknown [IPv6:2a02:a03f:994e:2800:14e:e8ed:4293:40fb]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: tijl) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V6N8K5Y7Sz1GDd; Sat, 30 Mar 2024 16:31:45 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Date: Sat, 30 Mar 2024 17:31:42 +0100 From: =?UTF-8?B?VMSzbA==?= Coosemans To: Yuri Victorovich Cc: Baptiste Daroussin , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d22f15315b93 - main - devel/gmake43: Corrections Message-ID: <20240330173142.4a8691fa@hal.tijl.coosemans.org> In-Reply-To: <56f4fdc0-f9fb-4578-ae25-88bfc5aad9f0@freebsd.org> References: <202403292007.42TK7lhI072363@gitrepo.freebsd.org> <56f4fdc0-f9fb-4578-ae25-88bfc5aad9f0@freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 29 Mar 2024 14:17:12 -0700 Yuri Victorovich wrote: > On 3/29/24 13:56, Baptiste Daroussin wrote: > > As I have been told by other this is not explicit enough, an explicit version of > > this email is: please revert gmake43 addition we are not at a point where it is > > actually required. > > > But should the users of science/nwchem do (at some point I was one of them)? > > With gmake-4.4.1 it builds for 20+ hours and times out. > > Try 'pkg search nwchem' - it isn't found. > > They aren't going to quickly fix the build. It isn't slightly broken, it > is broken a lot, and has always been. With gmake-4.3 it is also > unnecessarily slow, but passable. > > > Are you suggesting to just revert the change, and make NWChem broken again? > > Could you please elaborate how is this going to make thing better? > > Is it worse to have one extra devel/gmakeNN version used to work around > this problem and fix the failure, or to keep science/nwchem broken? > > > Looking forward to see how is your suggestion beneficial. > > > Thanks, > > Yuri > It looks like $(shell ...) is mostly used in one file, so maybe a patch like this is enough? diff --git a/science/nwchem/Makefile b/science/nwchem/Makefile index 52d0da8cb865..51ea75251551 100644 --- a/science/nwchem/Makefile +++ b/science/nwchem/Makefile @@ -86,6 +86,9 @@ post-extract-LIBXC-on: @${LN} -s ${DISTDIR}/${DIST_SUBDIR}/libxc-${LIBXC_VERSION}.tar.gz ${WRKSRC}/libext/libxc/ post-patch: + @${REINPLACE_CMD} \ + '/^[[:space:]]*[[:upper:]_]*[[:space:]]*=[[:space:]]*$$(shell/s/=/:=/' \ + ${WRKSRC}/config/makefile.h @${REINPLACE_CMD} 's|nwchrc="/etc/nwchemrc"|nwchrc="${PREFIX}/etc/nwchemrc"|' ${WRKSRC}/util/util_nwchemrc.F pre-build: