From owner-freebsd-bugs@FreeBSD.ORG  Wed Jan 26 00:40:43 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 373B416A4CF
	for <freebsd-bugs@freebsd.org>; Wed, 26 Jan 2005 00:40:43 +0000 (GMT)
Received: from kane.otenet.gr (kane.otenet.gr [195.170.0.27])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A7DEC43D3F
	for <freebsd-bugs@freebsd.org>; Wed, 26 Jan 2005 00:40:39 +0000 (GMT)
	(envelope-from keramida@ceid.upatras.gr)
Received: from gothmog.gr (patr530-a120.otenet.gr [212.205.215.120])
	j0Q0eY9C029460;	Wed, 26 Jan 2005 02:40:35 +0200
Received: from gothmog.gr (gothmog [127.0.0.1])
	by gothmog.gr (8.13.1/8.13.1) with ESMTP id j0Q0eYdq002671;
	Wed, 26 Jan 2005 02:40:34 +0200 (EET)
	(envelope-from keramida@ceid.upatras.gr)
Received: (from giorgos@localhost)
	by gothmog.gr (8.13.1/8.13.1/Submit) id j0Q0eXa3002670;
	Wed, 26 Jan 2005 02:40:33 +0200 (EET)
	(envelope-from keramida@ceid.upatras.gr)
Date: Wed, 26 Jan 2005 02:40:33 +0200
From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: Steven Smith <sos22@cantab.net>
Message-ID: <20050126004033.GA2640@gothmog.gr>
References: <20050125214606.GB1113@archibold>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050125214606.GB1113@archibold>
cc: freebsd-bugs@freebsd.org
cc: sos22@srcf.ucam.org
Subject: Re: Dubious #define in include/pwd.h
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jan 2005 00:40:43 -0000

On 2005-01-25 21:46, Steven Smith <sos22@cantab.net> wrote:
> I was messing around with sparse, the static checker used sometimes
> by Linux kernel people, and I (or rather, it) came upon the line
>
> #define _PW_VERSION_MASK        '0xF0'
>
> in /usr/src/include/pwd.h.  I can't immediately see any use for this;
> '\xf0' would probably be more useful.

If this is used as a mask for 'unsigned char' values, why would it make
any difference?  Aren't they both going to be implicitly converted to
the right typep anyway?