From owner-svn-src-all@freebsd.org Mon Jul 23 16:51:24 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7499E104FD32 for ; Mon, 23 Jul 2018 16:51:24 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E9D7A846CB for ; Mon, 23 Jul 2018 16:51:23 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-RoutePath: aGlwcGll X-MHO-User: 9f9ce29b-8e98-11e8-93fa-f3ebd9db2b94 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id 9f9ce29b-8e98-11e8-93fa-f3ebd9db2b94; Mon, 23 Jul 2018 16:51:20 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w6NGpJGJ013436; Mon, 23 Jul 2018 10:51:19 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1532364679.1344.161.camel@freebsd.org> Subject: Re: svn commit: r336619 - head/lib/libc/gen From: Ian Lepore To: Cy Schubert , Alan Somers Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Date: Mon, 23 Jul 2018 10:51:19 -0600 In-Reply-To: <20180723164115.40C7E948@spqr.komquats.com> References: <20180723164115.40C7E948@spqr.komquats.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 16:51:24 -0000 On Mon, 2018-07-23 at 09:41 -0700, Cy Schubert wrote: > I'm sure. Rolling this libc commit back addressed the ssh segfaults > on all my systems. > > --- > Sent using a tiny phone keyboard. > Apologies for any typos and autocorrect. > Also, this old phone only supports top post. Apologies. > > Cy Schubert > or > The need of the many outweighs the greed of the few. > --- > My current working theory is that some of the software that uses __pw_scan() pre-stages a pointer-to-empty-string into the pw_class field and my change ruined that by replacing it with a NULL pointer. Other callers of __pw_scan() don't do that, they just assume they're running as root and will get all the fields populated. -- Ian > -----Original Message----- > From: Alan Somers > Sent: 23/07/2018 07:48 > To: Cy Schubert > Cc: Ian Lepore; src-committers; svn-src-all@freebsd.org; svn-src-head > @freebsd.org > Subject: Re: svn commit: r336619 - head/lib/libc/gen > > > > On Sun, Jul 22, 2018 at 11:13 PM, Cy Schubert com> wrote: > > In message <201807222234.w6MMYKpn030237@repo.freebsd.org>, Ian > Lepore  > writes: >   > > > > > Author: ian >  > Date: Sun Jul 22 22:34:20 2018 >  > New Revision: 336619 >  > URL: https://svnweb.freebsd.org/changeset/base/336619 >  > >  > Log: >  >   Set the pw_class field to NULL when scanning the non-master > passwd file. >  >   This avoids a null pointer deref in pw_dup(), which assumes that > all >  >   pointers are either NULL or valid. >  > >  > Modified: >  >   head/lib/libc/gen/pw_scan.c >  > > >   > Hi Ian, >   > This causes ssh a bit of gas. >   > > > > > Are you sure, Cy?  Judging by the Jenkins output, I think it was the > next revision to pw (336625) that broke everything.  https://ci.freeb > sd.org/job/FreeBSD-head-amd64-test/8320/ . > > > > > -Alan