From owner-svn-src-head@freebsd.org Tue Sep 24 20:07:03 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DE53412FCC5 for ; Tue, 24 Sep 2019 20:07:03 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46dBzq36gqz3ws6 for ; Tue, 24 Sep 2019 20:07:03 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pf1-x443.google.com with SMTP id x127so1984856pfb.7 for ; Tue, 24 Sep 2019 13:07:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=UrwhRNwKfPeN7bUgmUhaWqowqJ5EUgAT10I25VdFHXI=; b=e+YpiWNIZLJ9Nb4tuNTJusR3LsLTziBlfBZwjlWB9UYQiLbfKNw0QWwiz7dt7v2/Qy RLXy1pO3lWaKF2ZS/sOsZ1CyKhrXc/cQYdDCzc3IhWNyovT3hvJ/qHfuH8HZ4eHj5IF3 WAgMJGwXUV3vhQaH96KsirzlNMeqd4jzo11FKOAnQTYeBM6zCWPJ26uzhGLLnjOPkV8p gy4l4dqLon2dBcnK+QE5jZI7xFqB3nYbhJppwrC1N93mlTo9R/GOW2hUKbTUF9O1dlzy 4ZWYpid85ynZov7ZouciKRU7IRJbH/LKvulzeHHw0V2U+bwhpBRjaUcD8LiDt+cLZZYL 1meQ== X-Gm-Message-State: APjAAAX0z+sRpkw7MkdV8AwGe9mtkxE3qo2p1j2vfBayzSm6OOC4feOO EQh0c5TVjHluzUkjltLNLSTcNg== X-Google-Smtp-Source: APXvYqxLpg84h37DFdqkhEC3beeLlqeX4++NvobNoreSK/zogwWEGnmU92h/u/N9gsSC0dseLRpp1w== X-Received: by 2002:a63:2884:: with SMTP id o126mr4672382pgo.279.1569355621616; Tue, 24 Sep 2019 13:07:01 -0700 (PDT) Received: from ?IPv6:2607:fb10:7021:1::eb2d? ([2607:fb10:7021:1::eb2d]) by smtp.gmail.com with ESMTPSA id 16sm2705017pfn.35.2019.09.24.13.07.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Sep 2019 13:07:01 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: svn commit: r352657 - in head/sys: conf kern modules/tcp modules/tcp/bbr netinet netinet/tcp_stacks sys From: Randall Stewart In-Reply-To: Date: Tue, 24 Sep 2019 13:06:58 -0700 Cc: "O. Hartmann" , Randall Ray Stewart , src-committers , svn-src-all , svn-src-head Content-Transfer-Encoding: quoted-printable Message-Id: <56FBEE27-FBDA-44E0-BBBF-F5D9A4755047@netflix.com> References: <201909241818.x8OIIBNr039667@repo.freebsd.org> <20190924212918.01e52920@thor.intern.walstatt.dynvpn.de> To: Li-Wen Hsu X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 46dBzq36gqz3ws6 X-Spamd-Bar: ------------- X-Spamd-Result: default: False [-13.57 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; RCVD_IN_DNSWL_NONE(0.00)[3.4.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(-1.07)[ip: (-0.46), ipnet: 2607:f8b0::/32(-2.63), asn: 15169(-2.19), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Sep 2019 20:07:03 -0000 Right Thats because GENERIC does not add the optional TCP stacks. Ok the problem is fixed with r352659 The tcp_ratelimit.h had a mixed up ifdef i.e. #ifdef RATELIMIT #ifdef _KERNEL definitions #else macro definitions that return error #endif #endif Which should have been the opposite #ifdef _KERNEL #ifdef RATELIMIT =20 definitions #else macros def=E2=80=99s returning errors #endif #endif Reversing that will fix the issue if you add the extra stacks but fail = to add RATELIMIT R > On Sep 24, 2019, at 1:01 PM, Li-Wen Hsu wrote: >=20 > I mean the head (r352657) world and GENERIC kernel can be built > successfully on 12.0-R, which is we guaranteed. > Also the LINT kernel build is fine on CI: > https://ci.freebsd.org/job/FreeBSD-head-amd64-LINT/13781/ >=20 > So I was curious about the build environment of that build failure. >=20 > Best, > Li-Wen >=20 > On Tue, Sep 24, 2019 at 9:55 PM Randall Stewart = wrote: >>=20 >> 12.0R would not have BBR .. its only in head=E2=80=A6 hmm it could be = a issue with TCP_RATELIMIT not defined >> though I did compile GENERIC without the extra stacks (and without = rate limit and hpts) and that >> compiled ok.. >>=20 >> R >>=20 >>> On Sep 24, 2019, at 12:49 PM, Li-Wen Hsu wrote: >>>=20 >>> On Tue, Sep 24, 2019 at 9:29 PM O. Hartmann = wrote: >>>>=20 >>>> -----BEGIN PGP SIGNED MESSAGE----- >>>> Hash: SHA256 >>>>=20 >>>> Am Tue, 24 Sep 2019 18:18:11 +0000 (UTC) >>>> Randall Stewart schrieb: >>>>=20 >>>>> Author: rrs >>>>> Date: Tue Sep 24 18:18:11 2019 >>>>> New Revision: 352657 >>>>> URL: https://svnweb.freebsd.org/changeset/base/352657 >>>=20 >>> ... >>>=20 >>>> This break kernel builds: >>>>=20 >>>> [...] >>>> = /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:5613:9: = error: implicit >>>> declaration of function 'tcp_chg_pacing_rate' is invalid in C99 >>>> [-Werror,-Wimplicit-function-declaration] nrte =3D = tcp_chg_pacing_rate(bbr->r_ctl.crte, ^ >>>> = /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:5613:9: = error: this function >>>> declaration is not a prototype [-Werror,-Wstrict-prototypes] >>>> = /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:5613:7: = error: incompatible >>>> integer to pointer conversion assigning to 'const struct = tcp_hwrate_limit_table *' from 'int' >>>> [-Werror,-Wint-conversion] nrte =3D = tcp_chg_pacing_rate(bbr->r_ctl.crte, ^ >>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --- all_subdir_toecore --- = Building >>>> = /usr/obj/usr/src/amd64.amd64/sys/THOR/modules/usr/src/sys/modules/toecore/= toecore.ko --- >>>> all_subdir_tcp --- = /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:10443:4: >>>> error: implicit declaration of function 'tcp_rel_pacing_rate' is = invalid in C99 >>>> [-Werror,-Wimplicit-function-declaration] = tcp_rel_pacing_rate(bbr->r_ctl.crte, bbr->rc_tp); ^ >>>> - --- all_subdir_tpm --- >>>> =3D=3D=3D> tpm (all) >>>> - --- all_subdir_tcp --- >>>> = /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:10443:4: = error: this function >>>> declaration is not a prototype [-Werror,-Wstrict-prototypes] --- = all_subdir_trm --- >>>> =3D=3D=3D> trm (all) >>>> - --- all_subdir_tcp --- >>>> = /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:14307:21: = error: implicit >>>> declaration of function 'tcp_set_pacing_rate' is invalid in C99 >>>> [-Werror,-Wimplicit-function-declaration] bbr->r_ctl.crte =3D = tcp_set_pacing_rate(bbr->rc_tp, >>>=20 >>> CI completed a clean build on 12.0-R: >>> https://ci.freebsd.org/job/FreeBSD-head-amd64-build/14672/ >>>=20 >>> What's your build environment and platform? >>>=20 >>> Best, >>> Li-Wen >>=20 >> ------ >> Randall Stewart >> rrs@netflix.com >>=20 >>=20 >>=20 ------ Randall Stewart rrs@netflix.com