From owner-svn-src-all@FreeBSD.ORG Mon Jan 6 12:06:06 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 34F50B48; Mon, 6 Jan 2014 12:06:06 +0000 (UTC) Received: from mail-wi0-x235.google.com (mail-wi0-x235.google.com [IPv6:2a00:1450:400c:c05::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 52E2B199A; Mon, 6 Jan 2014 12:06:05 +0000 (UTC) Received: by mail-wi0-f181.google.com with SMTP id hq4so2713659wib.2 for ; Mon, 06 Jan 2014 04:06:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=Mx2oee/YEkYRG3KJV98M3m869TeqvRVrwjRBDPjPFh4=; b=fX348jJM0ePFN8yQikgLzCcW3XdRiTqjTirg2Qo7D2a9XPzD/s1YcrzQ0Qcar+MwOU 8qQb5EEZgn8OCie9l3b7mmGmj1yfX813C4/Eqyl4HV0e5ZUUMZ8wJXhyNU9xBvVMP2uJ 0YhsHGUaHNC4h2WXyBVVojNbBL97xjtxth90gQFok5RGgWydpPxsQNhQNSmTJ1Gn3MXo SIrXUMLhJkSQ7mubZV8RNRc3UEivfxzeBjZ+kRfqWB+CQFyx0VwWkZtGFhVODuXqi5sk nPRh1zMYwESgdrQpoxX+IbDul1nQ/Gtnj302bpEWL+HvtmWZDRz+N3nUpec6yYefsWcx LVIg== MIME-Version: 1.0 X-Received: by 10.180.21.204 with SMTP id x12mr12086194wie.45.1389009963528; Mon, 06 Jan 2014 04:06:03 -0800 (PST) Sender: zbodek@gmail.com Received: by 10.217.112.65 with HTTP; Mon, 6 Jan 2014 04:06:03 -0800 (PST) In-Reply-To: <1388976912.1158.331.camel@revolution.hippie.lan> References: <201401012003.s01K3ngn009757@svn.freebsd.org> <1388976912.1158.331.camel@revolution.hippie.lan> Date: Mon, 6 Jan 2014 13:06:03 +0100 X-Google-Sender-Auth: EL8Kus9PMlV1p8VnXgyHtQh1Kww Message-ID: Subject: Re: svn commit: r260161 - in head/sys/arm: arm include From: Zbigniew Bodek To: Ian Lepore Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jan 2014 12:06:06 -0000 2014/1/6 Ian Lepore : > On Wed, 2014-01-01 at 20:03 +0000, Zbigniew Bodek wrote: >> Author: zbb >> Date: Wed Jan 1 20:03:48 2014 >> New Revision: 260161 >> URL: http://svnweb.freebsd.org/changeset/base/260161 >> >> Log: >> Add polarity and level support to ARM GIC >> >> Add suport for setting triggering level and polarity in GIC. >> New function pointer was added to nexus which corresponds >> to the function which sets level/sense in the hardware (GIC). >> >> Submitted by: Wojciech Macek >> Obtained from: Semihalf >> >> Modified: >> head/sys/arm/arm/gic.c >> head/sys/arm/arm/intr.c >> head/sys/arm/arm/nexus.c >> head/sys/arm/include/intr.h >> > [...] >> Modified: head/sys/arm/include/intr.h >> ============================================================================== >> --- head/sys/arm/include/intr.h Wed Jan 1 19:38:15 2014 (r260160) >> +++ head/sys/arm/include/intr.h Wed Jan 1 20:03:48 2014 (r260161) >> @@ -68,6 +68,7 @@ >> #endif >> >> #include >> +#include >> >> int arm_get_next_irq(int); >> void arm_mask_irq(uintptr_t); >> @@ -77,6 +78,8 @@ void arm_setup_irqhandler(const char *, >> void *, int, int, void **); >> int arm_remove_irqhandler(int, void *); >> extern void (*arm_post_filter)(void *); >> +extern int (*arm_config_irq)(int irq, enum intr_trigger trig, >> + enum intr_polarity pol); >> >> void gic_init_secondary(void); >> > > It turns out that the new #include in this change is causing the current > arm tinderbox failures. Enums can't have forward decls anymore, so the > fix for this may not be easy. > > -- Ian > > I apologize. I must have missed that somehow. I was assured that patches are fine. Best regards zbb