Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 1 Feb 2018 19:30:03 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r328707 - stable/11/sbin/nvmecontrol
Message-ID:  <201802011930.w11JU3f4020844@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Thu Feb  1 19:30:02 2018
New Revision: 328707
URL: https://svnweb.freebsd.org/changeset/base/328707

Log:
  MFC r308848 (by imp):
  Remove check for valid log pages. Let the drive tell us which pages
  are valid or not. While many pages are reserved in the standard, that
  doesn't make them invalid and future versions of the standard may
  define then.

Modified:
  stable/11/sbin/nvmecontrol/logpage.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sbin/nvmecontrol/logpage.c
==============================================================================
--- stable/11/sbin/nvmecontrol/logpage.c	Thu Feb  1 19:28:00 2018	(r328706)
+++ stable/11/sbin/nvmecontrol/logpage.c	Thu Feb  1 19:30:02 2018	(r328707)
@@ -757,14 +757,6 @@ logpage(int argc, char *argv[])
 				    "\"%s\" not valid log page id.\n",
 				    optarg);
 				logpage_usage();
-			/* TODO: Define valid log page id ranges in nvme.h? */
-			} else if (log_page == 0 ||
-				   (log_page >= 0x04 && log_page <= 0x7F) ||
-				   (log_page >= 0x80 && log_page <= 0xBF)) {
-				fprintf(stderr,
-				    "\"%s\" not valid log page id.\n",
-				    optarg);
-				logpage_usage();
 			}
 			pageflag = true;
 			break;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201802011930.w11JU3f4020844>