Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Feb 2021 07:05:09 +0000
From:      bugzilla-noreply@freebsd.org
To:        fs@FreeBSD.org
Subject:   [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash
Message-ID:  <bug-253158-3630-pOAUekki3a@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-253158-3630@https.bugs.freebsd.org/bugzilla/>
References:  <bug-253158-3630@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158

--- Comment #40 from Kirk McKusick <mckusick@FreeBSD.org> ---
(In reply to Konstantin Belousov from comment #37)
Doing the vnode_pager_setsize() after setting the size is clearly the corre=
ct
fix.

The previous code did not call vnode_pager_setsize() but worked because lat=
er
in ffs_snapshot() it does a UFS_WRITE() to output the snaplist. Previously =
the
UFS_WRITE() allocated the extra block at the end of the file which caused i=
t to
do the needed vnode_pager_setsize(). But the new code had already allocated=
 the
extra block, so UFS_WRITE() did not extend the size and thus did not do the
vnode_pager_setsize().

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-253158-3630-pOAUekki3a>