From owner-freebsd-current@FreeBSD.ORG Thu Mar 22 17:52:02 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 393C816A403 for ; Thu, 22 Mar 2007 17:52:02 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from out5.smtp.messagingengine.com (out5.smtp.messagingengine.com [66.111.4.29]) by mx1.freebsd.org (Postfix) with ESMTP id EF96F13C48A for ; Thu, 22 Mar 2007 17:52:01 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from compute2.internal (unknown [10.202.2.42]) by out1.messagingengine.com (Postfix) with ESMTP id ABF4520A593; Thu, 22 Mar 2007 13:51:58 -0400 (EDT) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute2.internal (MEProxy); Thu, 22 Mar 2007 13:52:02 -0400 X-Sasl-enc: DJrVzzbBNwBpVsl43sqrLDOhitYhyFtuvOF+Tgt/HsXz 1174585921 Received: from [192.168.123.18] (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTP id 423161C1AB; Thu, 22 Mar 2007 13:52:01 -0400 (EDT) Message-ID: <4602C23F.3060400@FreeBSD.org> Date: Thu, 22 Mar 2007 17:51:59 +0000 From: "Bruce M. Simpson" User-Agent: Thunderbird 1.5.0.9 (X11/20070125) MIME-Version: 1.0 To: Scot Hetzel , Denis Shaposhnikov , david@catwhisker.org References: <46025922.4090809@vlink.ru> <790a9fff0703220825g69405b89j123f7be87fadcb10@mail.gmail.com> <4602B42D.5060102@FreeBSD.org> In-Reply-To: <4602B42D.5060102@FreeBSD.org> Content-Type: multipart/mixed; boundary="------------020506060009020300030706" Cc: current@freebsd.org Subject: Re: no network access on today's CURRENT X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2007 17:52:02 -0000 This is a multi-part message in MIME format. --------------020506060009020300030706 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Are you using any FreeBSD networking features which put the interface into promiscuous mode? e.g. vlan, netgraph, if_bridge? If so, Yar has found a typo in the code, which did not get enough testing before commit (despite my request on -net for volunteers to do so). Can you please try this patch? regards, BMS --------------020506060009020300030706 Content-Type: text/x-patch; name="promisc.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="promisc.diff" Index: if_ethersubr.c =================================================================== RCS file: /home/ncvs/src/sys/net/if_ethersubr.c,v retrieving revision 1.225 diff -u -p -r1.225 if_ethersubr.c --- if_ethersubr.c 20 Mar 2007 14:29:54 -0000 1.225 +++ if_ethersubr.c 22 Mar 2007 17:51:31 -0000 @@ -669,15 +669,14 @@ ether_input(struct ifnet *ifp, struct mb #endif { /* - * If the frame was received promiscuously, set the + * If the frame received was not for our MAC address, set the * M_PROMISC flag on the mbuf chain. The frame may need to * be seen by the rest of the Ethernet input path in case of * re-entry (e.g. bridge, vlan, netgraph) but should not be * seen by upper protocol layers. */ if (!ETHER_IS_MULTICAST(eh->ether_dhost) && - (ifp->if_flags & IFF_PROMISC) != 0 && - !bcmp(IF_LLADDR(ifp), eh->ether_dhost, ETHER_ADDR_LEN)) + bcmp(IF_LLADDR(ifp), eh->ether_dhost, ETHER_ADDR_LEN) != 0) m->m_flags |= M_PROMISC; } --------------020506060009020300030706--