Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Jun 1999 13:38:40 -0400 (EDT)
From:      Brian Fundakowski Feldman <green@unixhelp.org>
To:        hackers@FreeBSD.org
Subject:   dd(1) changes (review please)
Message-ID:  <Pine.BSF.4.10.9906181230260.75966-101000@janus.syracuse.net>

next in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
Would someone (being more experienced than I) review these modifications to
FreeBSD (HEAD)'s bin/dd?  In my changes, I've tried to convert every random
"int", "u_long", etc. to the proper types ("off_t", "u_int64_t", "{,s}size_t",
and keeping the ints that SHOULD be ints), which I am pretty sure I've
done properly. I've also removed bogus casts, added new ones, and generally
cleaned up the code into a more maintainable lump.
  I suppose by learning the code and doing the cleanups/fixes, I've designated
myself as the maintainer of dd(1), haven't I? *grin*

 Brian Fundakowski Feldman      _ __ ___ ____  ___ ___ ___  
 green@FreeBSD.org                   _ __ ___ | _ ) __|   \ 
     FreeBSD: The Power to Serve!        _ __ | _ \._ \ |) |
       http://www.FreeBSD.org/              _ |___/___/___/ 

[-- Attachment #2 --]
j7[}SH|w	6^r#䎻r@m咥1VaK$|F/%UOՓ {qN_Bۓ0m/ζ|؞}
a&mmߖ8งCgeY*,ޡ'Y~{/`ߟ^,Ї/qtx
nןy)lz:A&C$7aR'+xGםk'ou*KQQ3WAcK?6Iy1:RO.R¹n7ND
GiYώw=	%	v,[w:_
ț<o>}/%/`)\(OϳO6lr8Ό@24<l80Go6g("I:zl|l<暠(/|I?"d%RL^m]c~7{Lx8䲩-ƟxJzK۳Mc5[z{NOE
RcLu/K8ygڛ.&Tb!EJrFoS%>X^I>=\{6+{z͒
h+h;o ^eP}Nq4d{Q0HuF8Mp:ph82ȽA(/+,m\
2x99Ra[/q%19Juo wRD*
SMi%$i<p48gؾ<״+8=qV,;	F
4^G=*{S@m:[(BU5ڒTCٱMn3ԜVb9)pNSیCk%j\'hCRg_Zw˃{L>a[w-"%βx +2XόPv<ex=OɎjGct~]w0<=
w(~M{U۝G_P6?UE{zq`%e"@"6l;&2Y^Xߵdc	&>]Vx^5Gm+\"h~1%bU!᫂yB]j8ʡxi/=옅 މ@|MR<L)NcatM8p1`eu$[k֏H\ற(5$q3Z.&C:B&w</ۓߔAl̡c;dM4D."R/_q̳Dz7^d4O	$;CC{)Q,y#ٮg<lX+~ H6::XhG|#y؉0(wgw{=h-	ȡ?@I-y!MZZXWfj.)e!CvE22R, 8
ׂfMn [5B9tï=x19Dr۔=G:FaGݥϽI~q>	&7f?]FH>O׹bsU}]7{
16a9t6bX$7lkcth1cm%nX=%e_`=pvQm'ưaY]LInxIaQR,CL\plN	AK	X'NFśXR?=#rׅ:ͥ)?l^i*,RH2Vf._yb6gN[l(~Al<EvFdLL,5E^D@/"-}gK]X_DWMk~zȇGU
=ď_6`W8|!7Z]%4pS,脂:b
YySͣd`]FF{jpM*l.k8TLFƽJS7.Gfelr5+5(jtA_Q-23CrmѲDjӄ:UtHGƾ_L8~q>ê;ײwUVJzJBJH9}A&X)=E?flⵕ5ed$oc:J5ހBVZzW<Y@w iH=DǨUj%&:'=uJPrv䃼gim+p	z	W$fH!*%u7)#!>G(Hd@?NLD`]fK8Ҍ5#?J}xࢊ.KjcqB̔D!Sc]h`rXCqno1'I;5E|Etkeq%lv5訵g9r}Z]^9==}wrv΁=mC`RuoG:!OtZ`=Ĩ
STPʄZ_K<kӿLs:!Xxw0MT矋yZP3ƳeP$'XZƪ4JUmrM_4to߽˥
oNޒߟ91,rKѪDӄZ
wejSbo2)<-<J]LɉPp|-z)*
f=Y5RѠ@&%WCû0
2ZՉT%]U|\T[=E':_?_]|<;zWһ4ANyϨ|o@MU,*}籞NU)t3r.eHF't<O"*!XBOԈhd\>Ї1aFFr>G_p{A\E[H,ϑny+ҘǥaMaEvb20w%ž̄͠c\gX]QCW;<OQte[ffjH	t:R	ye@׉dM*W䉲:px{-O_nFjA8_M+bf]ߕ!)p~yoT2Liםyf$@MY]:9ԝ#8>GQY2TYE
wԉ{$z/FD6Gh3[]H+4+~kf
`*
lg>[PgjbaՕt4,e!EA@g|w&U%\f38C<	(0k*762{=ir7z)`Zucm7_|0c&.7Q.Y!dSLQǫU}zy
\Ϥ3&2,*)AP"Ow%Kٙ+~_'j+Z]zdVd#z;)=y$q֒ZRSS:.w\IQkT*<Ow{"	QL@LHd2ŧR<i5	E[-d.D}6{~:VԞ6JHS%:Y)݀RY
}֑V]Nu%;{J꤅"{3.ȣ,r#G?wtË|8.-vZJz^28pܮLC\:]4+.X{P
xO۟RWN(%@6PQO$PjXFEX+V6GB)z:&TUT'iز[zgR
jer]:r!؏zMҠOyd-j#݃
w8=gdXŨO,IXIAXɂAVpe5<+4v*9ӤF"gmbSL0-yETqeغԭlkc6hWHn#g{c?tH-d	%58PLCpLA+`l%_1GM(p@?	2
]Qbv_2x
ے
+rFE[
Lw^'zks‡jjɉ]-꣥Zs)F;\z9_ɢ|C_w䛆4zS%=(FJY<uO1K8zd C3!Do$O4?R}"JRiw؃,\jAmAD%)$8TMq-?%@Ϋϗ/A}m轟u[U֟ןk,6bQ䱍.՟Q1]^9PerPh#2(\cׇlu35^*R*مr;=sP]C)[Sy
q/7iX;Jcn[rխ\Fc5}7OZ+pp;FpI|kUuKO]ԯD\zT:p^ju/u_ttHil/ɾc?je}uٓo2j=eH*Uͨ	IB[٨!qmuR/#p<4tՠLj{	8VfÍ4=YF5)dK$GzrrLs$w8Ci\Iªl<k+ 5J-/OgԚ37_g8ieTqtl#C!yW~>/t~uz~|uݫ>@ّ)\!jE4'(k=x~8(0UT+uX'#`<

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9906181230260.75966-101000>