Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Jun 1999 13:38:40 -0400 (EDT)
From:      Brian Fundakowski Feldman <green@unixhelp.org>
To:        hackers@FreeBSD.org
Subject:   dd(1) changes (review please)
Message-ID:  <Pine.BSF.4.10.9906181230260.75966-101000@janus.syracuse.net>

next in thread | raw e-mail | index | archive | help
  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime@docserver.cac.washington.edu for more info.

--0-1793103162-929727520=:75966
Content-Type: TEXT/PLAIN; charset=US-ASCII

Would someone (being more experienced than I) review these modifications to
FreeBSD (HEAD)'s bin/dd?  In my changes, I've tried to convert every random
"int", "u_long", etc. to the proper types ("off_t", "u_int64_t", "{,s}size_t",
and keeping the ints that SHOULD be ints), which I am pretty sure I've
done properly. I've also removed bogus casts, added new ones, and generally
cleaned up the code into a more maintainable lump.
  I suppose by learning the code and doing the cleanups/fixes, I've designated
myself as the maintainer of dd(1), haven't I? *grin*

 Brian Fundakowski Feldman      _ __ ___ ____  ___ ___ ___  
 green@FreeBSD.org                   _ __ ___ | _ ) __|   \ 
     FreeBSD: The Power to Serve!        _ __ | _ \._ \ |) |
       http://www.FreeBSD.org/              _ |___/___/___/ 

--0-1793103162-929727520=:75966
Content-Type: APPLICATION/octet-stream; name="dd.patch.gz"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.BSF.4.10.9906181338400.75966@janus.syracuse.net>
Content-Description: 
Content-Disposition: attachment; filename="dd.patch.gz"

H4sIAKODajcAA81bfVPbSNL/23yKDncJNpLBkoEAXnKbI+SOuwRyQO5ts+WS
pTFWYUuKJIewm3z36+6ZkUYv5iVVT9WTqiB71N3T09PT8+uecRBOp9BfQpb6
25Mw2g6CbS+9zrZ82J7FC7F9nQphtK71+/0mbedtGsLflhE4++C4h4ODQ2cI
zsHBwZplWe2CKizDw+HeobMnWX7+Gfp7L+2XYPHfn39egyz38tCHL3EYdKbj
eArj8Ydu1595KWz2eqM6QSbEzUMkN2FSJ+krkuV4HkfXnWuRjyfZb3UqS1GF
Ub63M85XkUHRY5anSz8HHDb8vgYdSRJ5CzHioTqDoe0OwFJPGi5S3c7CuYBu
N05ECkewaVnI/6UHz47g7OO7dz0W1QmnJQl2EywT/tbrwZGiW+t3Oh2Rpl+7
jg3ry8iboNg8Bm8+j30vF5Alni9gGqeQzwQpuVyIKIdP68+zT+vrNmxyvzjs
H5OzzoxA/9YbMvUIyDQ8AH+W8gBs2DjaMEcB1d5vovg2AqL0ogCeZyiTx80i
STp63RFsfBpsFJ08o+aaoCiGL958ScoLP5yGIuAB1OTli2SLpgslUuOITMoS
u16CbV1jfjd7k0x4OIzuC+SyqS2ziZ7Gn4W/iXhKg8162+pLyduzoaVN8/pj
+trrkTWNvlt6e7AbnpBOqU9FhaKfhw2uzVLOYxBM5951Bi/AS/qvojgTec3/
nmeHEM7n4tqbly7ixwsMJrhUYuwhRY9KhRfcAXKv8/jZAEZv1lMlmj5YkV4b
g9b/2xEPAEm4mT6zPZnqu1y0e7s2xiuLnnt6zZINwmgroGiAnjuAb98gXuZl
A5u1UH2ynE5x5dI0ZOB7URTnMBHwm0jjdYpGOPbtTfwDm3CBOttwm4a40GgC
OMD5uPYyyL0bQbEoAy8rLJBtAVwSDQuXMvx4OQ+ogzlSYb+o7a2AWy/K0e1x
JQcxhDlKorB1jRqh4fyZ8G8gjuZ3UkQqrpfIDVOMTehpkyXS5xsZJGk8wYBw
BzSE2zjNZ9i+xTzb+Ne0yys4Pbsav3/974pxilb2l4cshDsJRhwKNF4EzwOc
R809KnuLp1OcQKO/bdA6qJ5bKLRCVTXY2pLaVEPZsU0L+G7Ef5wc6TMHA9rU
nP2B2tXUVoBikAPjOSmv3cdwHBpO3lPbjPJDawUlmWpcJ65oQ/ufUmdfqrO/
Wh3/HgX8p3fpDva4y4O9e7pM7sY+rmGUvBy39lsStHctA6Qi4yWHzrKgeCC6
A6kbK+PukjKus6uU+b1YxM+MUHY8/vNlj/2htHirPcz3T7HJjstqDN1HqvGQ
Y3R+0B/cXfYHd+cefzCWzcr5qdA8quM99gp39x6vKBf0yn5Nknu6VdudH0df
UDb1PxwM7APs/4AeVfhFe3oVcRlgACVlIum+QCIMEjbHbL07+yYy4L7q0MCf
h1lexwbcWN+1ib2BDmRjCQ/4u4kP/CY+kF1W+4LtFXjgvl41R9ltK1yglyLN
aBd+EDH4JWKAVfu7Ic/Y4auCeUJdhxxq6DjKoXj+aS/FPeyYhSDeiUB8TVKR
sTxMKQi2TmOEs7dhdE04cJExwI1gGWXhdYS7JKUFW2vWj0iBvZ3+hPfXXOCu
sbUGKKXj9OA1JHEW5uEXAQGC0AWOM1ouJoqk495DoTpCxSZ32MMEuovlPKcv
u47bk/zDx/PflPzOwN1BAWzMoWM7ZE00qrPL5kSx5C4i8VIvl9xfca3MsxjH
RAB64vk3t14aZDRPCc7SJJyH+R25EwPtO7SNFkMGQ/wQkHsp+4VREPosmdF5
xiPZrqVn9TxsrVj0yNQrggh+4SDS70g2Gjo6jAwYzFi0aBaa0BFHHXwj13mO
2Ink2vCC3towKKAG0xzBx3fnZ3/h3R+9d3sTztE9pmjcLQmByKGVP5e5hRRA
AkkCqS15zxCMhdchobhNWp6GGp8bWlimFv/4+PqNBlfU9JMEoWYXFQhqri6k
FynFZbK5kQAhQ3Yb5hhF2DIUB88RETJSLOoAhyCz+q04Da/XgmZNgdZus6Yg
W+s1Bdn6pJpCC8vw0Nk5dA+MmgLDrz2Nvnj/wRUx7fakg4SUOUTsGnLblN8A
PUc6RhhhEN3MR8UG3aW9xs+9SZmXq5R+h3EOPva5rwkmyTeyH7Rm4bf0P11G
/kj3PrOpTxsW3te5iJSTYnNVp/J9XTfcew0VMeKxNg6pYTkIdKQ2BOXnYpqD
WCT53RY3bBf5C2vUY4t0aDFjE20ljG5YPf0lZfPoHQjbX7xgPXB2nlHyHW2M
oN8nDMaw5GFZ9wvhXadM56lJbskSeElhg1HZUvSk6ixDTNlctMNwj55siLpO
CfRBS7MJWCcFvk5GxZuR6ljOAlK8Pz3rEhy2CxKjuNHiI5TUcteF0jrNpYaf
1PSSKbr+jKo/bJBeaRHLKixSkfNI/jIfVoLIZh32Hi6c5L/4s195BGKeif/3
6tL6AIqc9Jc2Z05bqadshskopq1+nAaAQWyGPLjTReJ2HkYCk2RMrLNMLLiY
NRNFXkTL5eBAL5cify19zsLdZ0utXfIEsVjEX0RXuYrd5k2Ga6D5uhR+esiH
kEezgVWSF+sKPQf+xI9fNmDjVzgEfODaIYDfN4VaDwtdJa00cFMs6ISC5so6
YgpZB9F5lLNTzaNkYF1GRtB7anDFTfAq9aJsLms4VPLwvUwYCJC3RpnGveRK
jOvu01PHNy5HZmVsq6/0cjXDKzUooNdqhOV0QV+2mBFRhi0yrbKXMwKWQ40U
wHLabdGyFLvM8PdExmrI04Q67MlVlPN0kUhHxr4WX0w41srJ7BR+caSnoD7D
qvU7jdeyineyuKrYVYGVVqdKekoZr46MQopKSAw51ffUfRCMsUEm5+RY1RWn
0uSXHL0pPUUc0PCzsT/H7OHR3mZs4rWVjbg1+tplZCSjB5pvqWPIOvuFSjWq
3oBCjKVWmVp69bBXPFlAq3cgaZt/SOGrPUTvx6hVG7iT8GoluAuCJrSjtjqw
o7YnwboGw/DQ3T3cdUpQ93LHdhyw5IO84vQcZ5/37hGDaZ6+bdorcBYJegkO
CJdXr68QiY0k4mZIliEqy/glnxF1N/0pIyE+2OHI2hsRsZGGEgFHKAL56thI
FZ5k73+gnIYdlNNAP07uTNpEYKoTXfNmyPS6gUuOOK0YxtKMNbakIz9KvKZ9
gnjgooougUtqY6BxQsPMlO5EySGzU6djXbhoYJByuVjV7BxDcW5v0/sxsq0n
SQa58DubtPU1Red8nEV0a2W51nElbHY1DuiotY+drWc5GnJ9pFqnAbZdXr05
PRu/PX13cnbOgQwIPcltQ9NgUhV1lRgbzscXb87P3v1H55M6HiHpT3RaYD3E
qAqPBReGh75TVFDKhLMMWhxfSzzsEB7e1WuH0dO/FEyicxI6IVh4dzDzvgjE
TVTnn4sFeY5aUJz0B7HIFDOVxrNlklDgJCfjHVgdAxS7hBoeWsaqNErtVfTS
bXLk9E0P/V8XNHT4Budv373+y6UNb07ektXfn785Mfa44izn7Pzi5PWbckur
qdGqRNOEWoOqDXdlarW7U/iI5mKkb8CnMhkpPIPTAxmbj+iwBP8t+Dy1q0qc
XUzl9cmJrVCIhA698nAUE3zF3C16qokpKsINZhq90e89/ZndWe3dNbqpnN/W
7VLP0aBAJhoeqLztJVfz5EPDu5swCjJa6coP1YlU7iX0oF1VfPUWyVxUs1uj
4Ng9Hp+/RSc6Hl+enPydP5ydX118PDuWelffy9K73AWmjPvpNEG6jI2WmE7H
ec+ofG+WCMdA5k3OVSwqfeexnk5VqMopdDMO9nIulGUUjPIQ/9DZH669mUiN
sEYndOE8AE8iqKGs7w/3m5cq1gAhWBiZ8ImrD5lCT5HUiNHKaGRcPtCHMZS7
YUYURuPpcj5HB5BfcHtBXEUAW5/GSCy3z5GHn24Zef4r0pjHpc79pmGa5bxN
3WGeRXYIYjKB3Aj4MJp3JcW+zIQB+82gYx6jXP4HZ1iv+cYLXVGovENX+PO7
8+O/fzsefzzjT6ri3VGplnRlW2Zmav2oSMQJdBvtwKS0OhxSkI7KCRR5ZUDX
iWRNKlf85ImyOsNw93iRuHv6FKkQuC1PjwGXX5xuGUaJakE4qsZfmU0r/4ti
ZpfhXd+VsCEIKYf+cH55+m9U+vMyTGnXnXm5ZqXJJEBNs7YQWeZdCzo5rdSd
IzjdPkdRWTL37lTNWR5FDXcP1IkMeyR6ny9GjRoayRfBqET9NqDnR7doM1sB
HF1IK7+ZxTSkDivOfmtmChRgKuW04cEeHRcNDw5sZ6CDPltQo6tnamL4Bb9h
1ZXPdDQs6/dlIUWSzBmTFYFB0dhA0Wd8/PGip3cmycLh1FUlXGaVM+TT2ThD
PAntKDCqaxQqxzc2Mqvaez2eaR0UHXI3lLEepcx6KQFgvapadWNtNxhffDBj
Ji4Ip6A3US7P0A4dWQzA2iFkU0xRscerVX16efzXCwpcz6QHFTMmvzKiLBsq
KaG8iEHHUOgink93EQLxJfQLS7fZmesr9dF+X6Ha1esPJ2qqK8X6Wv+03xVd
13oE498PyQClnrxkVmTv/SOIehg7qin8BKf6pj15pCTuvtRx1pL1zVpSx9lT
U8c6wy7yGHcMh1xJsOhRnGv98VQqPLO/gLO1T8T72wN3G7ergXvoDg+HDu61
3iKEk68J/FEeTMGa9YdATMNIwJIPlWQyxadSFh08wmk1CUVbLWQuygEZ8rtE
oAB9Nv17EX46m4HOVtSe6AUBnTZKSFMSJTqnWaYp3YBS1BRZDQ59CNaR9ZxW
lsldTnW2JbbIyzuUFcr6vKSfe5lKDuqkhfAiezMu8MijLJXgyXLkI/pHP5ad
2/d3znSrusXgreanw4u+0xl8HTiy89oChi4tdloWvEp6zF4yfzj9cMLcrkyn
Q1w6XdoUFbCjNLKnK5OYFLguWLt79FD3CnhP6cjbn1JXTiglQKWENlDNFBxR
p8xPwyTHUGoaWAJGRVgrAfC9VjYIx/BH0UIpejomt8zMVJrwnOLB/A/RVYbB
0VQnafAQ7Au9B9iyBlscBJDdehPNZ1LnDWplcl2WsDpy7ekh2I8YAnpN0qC+
T3lkyBoMLWoj3YMKw3c4PWdk0Vj+xagVnq5PhyxJtlhJQe6WqVjJgkGptQ8V
rFZwrOhlNZM8K+k0rIF2laXVKjnZ06RGG/fnIrrOZ20eoq9iU0wwLc7feafL
RVRxEmXYupPUrcQFGB5si4O0EGtj1uU27KJoV0huI2d72Q8ZkBwU7WM/ynRI
rC222mTQCeIlhjWC3DjnUBRMEUNw6olMQaAcmqqq5NIrYMBsJQwQXzEGR00o
oNvrcEC3PwkStDIND133EFFiAQt2XzJ4lA8K25INFyvownLRRuNFW5QNlEyD
rhx3qainXqjbJ7p6a7Rz1sKHapZq08mJpq23yxO4igBdt63JLeqjpZBacylG
pjtcH623eq4YD91//vKrzR854ZNfwsmifENfinfC9eSbhjR6U5DN3SU9lu6c
KNv8Rs/aSt9ZhJnfPH+QrXW/ka1P8hrF8h4xAbPsgEs4snq1ZI/PIOVD5huZ
8DPKIUR/byRPND9SfSJKUpyBaXfYgyzmXJlqrEEcbRCuQRxEuCUPwhgpJDhU
taOCE8FNcS0PP/MlQM6rns+XFv4vwkEYfYrqbei9n6J1W1Xw1p9/xtefayy1
Ns0C8qJiUeSxjRoPfy6Cn/7C1Z9RMQKZxV1evTm5uFBlcqpQ0WjyFCMUj6a4
wIsyKFypY9eHbMCj553YDHXPMzXYx/B/XskPKplSKtmFcpQFOz34E6xzUF2H
Q/UpW5f501MH/r0cvHkN53GjLzeEp467wWmMWO47pUr/B2NuW/Vy1a1c8/JG
Yxw11335pr72yzdPWv8r2HDfcA6HO0YMcLioSY8d43wa2WuVVXUVg0tPqV3U
r4qi1ESfXOt6VDrScF4fapt1L3Vfgqt0dLmlSGlsmZ/QL7LKFN/Gyb5j8M8/
aojohxplffwZlx112ZOTpW8y6/mmahI95ZJl0UgVKlXNqLyFvQnFSUJb2agh
4HGc9x5tdVKRL9PI+JmOI39w4Oi7PDQbdNWguIrHiHuRxwnk4zipVhEbZq+V
w40CvTQ92VkamAZGNSmqr8xkqUv9JEe1enJywkzq6cpzJHffOOPgQ7fyl2lc
8OdJk7/Cqp5sPGsrIDXmSpXQ9OWi+84tlO0vT67aZ+3eE4wW5vsP1JozN+Rf
ZzjFaQVlVHGytaC/dOXu6u3lxchslrWAI0MheYlXHo/Gfj4vdH5/dXp+fHX+
wYYXxN2rnAM+QPqDw9mRwyl/XCHLakW53zQn3cUoqms9eKV+ONbx4ygPo6Uw
xhVVVI8epZ26K9cWdctYJyPv/wBguBYOHTwAAA==
--0-1793103162-929727520=:75966--


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9906181230260.75966-101000>