From owner-freebsd-net@FreeBSD.ORG  Tue Jul 27 10:10:05 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EBBB9106566B
	for <freebsd-net@hub.freebsd.org>; Tue, 27 Jul 2010 10:10:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id DDB8A8FC18
	for <freebsd-net@hub.freebsd.org>; Tue, 27 Jul 2010 10:10:05 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o6RAA5sg068868
	for <freebsd-net@freefall.freebsd.org>; Tue, 27 Jul 2010 10:10:05 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o6RAA5Ip068862;
	Tue, 27 Jul 2010 10:10:05 GMT (envelope-from gnats)
Date: Tue, 27 Jul 2010 10:10:05 GMT
Message-Id: <201007271010.o6RAA5Ip068862@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/146539: commit references a PR
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jul 2010 10:10:06 -0000

The following reply was made to PR kern/146539; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/146539: commit references a PR
Date: Tue, 27 Jul 2010 10:05:49 +0000 (UTC)

 Author: glebius
 Date: Tue Jul 27 10:05:27 2010
 New Revision: 210529
 URL: http://svn.freebsd.org/changeset/base/210529
 
 Log:
   When installing a new ARP entry via 'arp -S', lla_lookup() will
   either find an existing entry, or allocate a new one. In the latter
   case an entry would have flags, that were supplied as argument to
   lla_lookup(). In case of an existing entry, flags aren't modified.
   
   This lead to losing LLE_PUB and/or LLE_PROXY flags.
   
   We should apply these flags either in lla_rt_output() or in the
   in.c:in_lltable_lookup(). It seems to me that lla_rt_output() is
   a more correct choice.
   
   PR:		kern/148784, kern/146539
   Silence from:	qingli, 5 days
 
 Modified:
   head/sys/net/if_llatbl.c
 
 Modified: head/sys/net/if_llatbl.c
 ==============================================================================
 --- head/sys/net/if_llatbl.c	Tue Jul 27 09:22:41 2010	(r210528)
 +++ head/sys/net/if_llatbl.c	Tue Jul 27 10:05:27 2010	(r210529)
 @@ -337,6 +337,7 @@ lla_rt_output(struct rt_msghdr *rtm, str
  			 * LLE_DELETED flag, and reset the expiration timer
  			 */
  			bcopy(LLADDR(dl), &lle->ll_addr, ifp->if_addrlen);
 +			lle->la_flags |= (flags & (LLE_PUB | LLE_PROXY));
  			lle->la_flags |= LLE_VALID;
  			lle->la_flags &= ~LLE_DELETED;
  #ifdef INET6
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"