Date: Fri, 22 Feb 2002 16:52:00 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: John Baldwin <jhb@FreeBSD.ORG> Cc: arch@FreeBSD.ORG, Julian Elischer <julian@elischer.org> Subject: Re: RE: that INVARIANT/ucred freeing stuff. Message-ID: <200202230052.g1N0q0t32377@apollo.backplane.com> References: <XFMail.020222191032.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
:>:John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ :> :> This doesn't make any sense whatsoever. *NOTHING* was using td_ucred :> until just a few days ago, so unless *you* are blindly changing all :> p->p_ucred's into td->td_ucred's, I don't see how it can become an issue. : :Yes, almost all the p_ucred's are changing to td_ucred. That is why we have :td_ucred. td_ucred doesn't need a lock, but accessing p_ucred does. Did you :read the description of td_ucred back when it was first proposed? : :> -Matt : :-- : :John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ I'm not an idiot, John, I know what td_ucred does. Remember? I'm the guy who has a bunch of piecemeal commits to remove Giant? My prior statement has not changed. It says exactly what it means... if you are so afraid of td_ucreds being used improperly then I'm asking whether you went over your p_ucred to td_ucred changes or whether you just made the change blindly. Well? Me? I much prefer to commit things one at a time. I've been holding on to my commits for over a week now hoping that you would commit something. I am not happy with having to wait. I am not happy with your intention to bring this whole mess into -current all at once. And I am not happy with your stuff apparently not using Giant instrumentation at all. You seem to be having problems debugging your own tree... maybe it's because there is so much fraggin stuff in it you can't figure out which pieces are causing the problem! After this I'm not going to wait or ask any more... not if every time I do I am forced to wait 2 weeks for someone else to finally commit something they've been holding on to in their own private environment. Not when it interferes with development so fragging much! Not when said person wants to taylor the kernel to work around his own problems rather then work his code to the other way. It has been an unbelievable, phenominal waste of my time. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200202230052.g1N0q0t32377>