From owner-freebsd-fs@FreeBSD.ORG Tue Jan 14 14:04:41 2014 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 69AB1486 for ; Tue, 14 Jan 2014 14:04:41 +0000 (UTC) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id B68F0188A for ; Tue, 14 Jan 2014 14:04:40 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA21850; Tue, 14 Jan 2014 16:04:32 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1W34bY-000Aun-1E; Tue, 14 Jan 2014 16:04:32 +0200 Message-ID: <52D543B7.2010407@FreeBSD.org> Date: Tue, 14 Jan 2014 16:03:35 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Slawa Olhovchenkov , freebsd-fs@FreeBSD.org Subject: Re: zfs locking References: <20140114133642.GM16734@zxy.spb.ru> In-Reply-To: <20140114133642.GM16734@zxy.spb.ru> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jan 2014 14:04:41 -0000 on 14/01/2014 15:36 Slawa Olhovchenkov said the following: > DTRACE_PROBE2(l2arc__read, vdev_t *, vd, > zio_t *, rzio); > ARCSTAT_INCR(arcstat_l2_read_bytes, // arc_read+2137 > hdr->b_l2hdr->b_asize); > > if (*arc_flags & ARC_NOWAIT) { > zio_nowait(rzio); > return (0); > } > > ASSERT(*arc_flags & ARC_WAIT); > if (zio_wait(rzio) == 0) > return (0); > > /* l2arc read error; goto zio_read() */ > > Is this locking issue? This looks like a bug that was already fixed in illumos and FreeBSD head. What version of FreeBSD do you use? See r258388 and r258389. -- Andriy Gapon