From owner-freebsd-hackers@freebsd.org  Mon Aug  3 16:19:56 2020
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6954537EEEC
 for <freebsd-hackers@mailman.nyi.freebsd.org>;
 Mon,  3 Aug 2020 16:19:56 +0000 (UTC)
 (envelope-from swills@FreeBSD.org)
Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client CN "mouf.net", Issuer "mouf.net" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4BL34r2FHBz434p
 for <freebsd-hackers@freebsd.org>; Mon,  3 Aug 2020 16:19:56 +0000 (UTC)
 (envelope-from swills@FreeBSD.org)
Received: from lrrr.mouf.net (cpe-76-182-16-135.nc.res.rr.com [76.182.16.135])
 (authenticated bits=0)
 by mouf.net (8.14.9/8.14.9) with ESMTP id 073GJl6V042153
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT)
 for <freebsd-hackers@freebsd.org>; Mon, 3 Aug 2020 16:19:53 GMT
 (envelope-from swills@FreeBSD.org)
To: freebsd-hackers@freebsd.org
From: Steve Wills <swills@FreeBSD.org>
Subject: SOL_LOCAL define
Message-ID: <50992471-7f17-dcdf-949f-1b0512a9b84d@FreeBSD.org>
Date: Mon, 3 Aug 2020 12:19:42 -0400
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mouf.net [199.48.129.64]); Mon, 03 Aug 2020 16:19:53 +0000 (UTC)
X-Spam-Status: No, score=0.2 required=4.5 tests=KHOP_HELO_FCRDNS autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net
X-Virus-Scanned: clamav-milter 0.99.2 at mouf.net
X-Virus-Status: Clean
X-Rspamd-Queue-Id: 4BL34r2FHBz434p
X-Spamd-Bar: /
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [0.00 / 15.00];
 local_wl_from(0.00)[FreeBSD.org];
 ASN(0.00)[asn:36236, ipnet:2607:fc50::/36, country:US]
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Aug 2020 16:19:56 -0000

Hi,

I ran into a case where some code I was building expected SOL_LOCAL to 
be defined since LOCAL_PEERCRED was defined. See:

https://github.com/nanomsg/nng/pull/1272

for details. And looking at getpeereid.c:

https://svnweb.freebsd.org/base/head/lib/libc/gen/getpeereid.c?view=markup#l50

I see:

         error = _getsockopt(s, 0, LOCAL_PEERCRED, &xuc, &xuclen);

I wonder if something like a:

#define SOL_LOCAL 0

in sys/sys/un.h and a change to the above to:

         error = _getsockopt(s, SOL_LOCAL, LOCAL_PEERCRED, &xuc, &xuclen);

might be useful for compatibility and clarity? Any opinions?

Steve