From owner-freebsd-current@FreeBSD.ORG Mon Aug 25 19:27:24 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9138E16A4BF; Mon, 25 Aug 2003 19:27:24 -0700 (PDT) Received: from ion.gank.org (ion.gank.org [198.78.66.164]) by mx1.FreeBSD.org (Postfix) with ESMTP id B690C43FB1; Mon, 25 Aug 2003 19:27:23 -0700 (PDT) (envelope-from craig@xfoil.gank.org) Received: from localhost (ion.gank.org [198.78.66.164]) by ion.gank.org (GankMail) with ESMTP id 27AFD2D1BA; Mon, 25 Aug 2003 21:27:23 -0500 (CDT) Received: from ion.gank.org ([198.78.66.164]) by localhost (ion.gank.org [198.78.66.164]) (amavisd-new, port 10024) with LMTP id 28895-06-2; Mon, 25 Aug 2003 21:27:22 -0500 (CDT) Received: from aldaris.auir.gank.org (dsl081-113-221.dfw1.dsl.speakeasy.net [64.81.113.221]) by ion.gank.org (GankMail) with ESMTP id B4B332BB30; Mon, 25 Aug 2003 21:27:21 -0500 (CDT) From: Craig Boston To: cg@freebsd.org, ume@FreeBSD.org Date: Mon, 25 Aug 2003 21:27:58 -0500 User-Agent: KMail/1.5.3 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200308252127.59003.craig@xfoil.gank.org> X-Virus-Scanned: by amavisd-new at gank.org cc: current@freebsd.org Subject: re: cvs commit: src/sys/sys soundcard.h vs. gkrellmvolume2 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Aug 2003 02:27:24 -0000 Cameron Grant wrote: > cg 2003/08/14 18:24:36 PDT > > FreeBSD src repository > > Modified files: > sys/sys soundcard.h > Log: > add a few missing bits for future use > > Revision Changes Path > 1.42 +27 -1 src/sys/sys/soundcard.h FYI, this change breaks audio/gkrellmvolume2 (when compiled from source; existing binaries should work fine). Just finished rebuilding all my ports on a day-old CURRENT and noticed that all the volume controls were missing. As far as I can tell it's picking up the recently-added SOUND_MIXER_INFO macro and puking when it finds out that the kernel doesn't actually support the ioctl for it yet. Admittedly, gkrellmvolume should probably have a better failure mode than ignoring the entire mixer, but it took me a little by surprise :) Umemoto-san: I'm not sure if this is worth putting a patch in the ports tree or not -- I guess it depends on how soon "future" is in the above statement. Anyway, I'm attaching a quick workaround if anyone else running current runs in to this. Happy hacking, Craig