From owner-svn-src-head@freebsd.org Tue Apr 4 13:53:55 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 86E88D2ED50; Tue, 4 Apr 2017 13:53:55 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it0-x234.google.com (mail-it0-x234.google.com [IPv6:2607:f8b0:4001:c0b::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4E2D0842; Tue, 4 Apr 2017 13:53:55 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it0-x234.google.com with SMTP id a140so28734594ita.0; Tue, 04 Apr 2017 06:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=v7xJEnQk40W+zqhe3vpGj2PmVbT3qRKkA3UmPCNa1UU=; b=mIwGqipG21HevIo3+tmfBTuIyB9XtvbE/PbGYwEez+4kOr4nRWcwEPZxI3C/C6tY22 yTJmKBEpE5L9PyN/6LNOmxabT6pg9at+EDXjm7rVu+v8AvITKl4NQEWc4w7y3kYO8zTy 3zyhzfGlo9De1SvptLDpELoVoTWDCMk3YFjc2os5dwFnmfn8VnVrv35T8vfWH6Wecdkg DElnDPHIJxfnK4Z1FR86iP0z9SVU/VUZD2C0klWFlZBmV8UY281swSlg1PNZnV20SOsy 8wCvX+ohhNvGhHxpvg6Xwmz47cvf+VSIuvt/tMq5MDGBXsOpEXPgAPLsOcut8L7VMwm0 FQMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=v7xJEnQk40W+zqhe3vpGj2PmVbT3qRKkA3UmPCNa1UU=; b=OMoUheihXaAs55ME/HycmTRWs8OxD2omZpcb/5SkO8mVs3nwTxDgBr1XvUbFlkOMw7 8gV8WTx80TcwoGtg8RTuNl+N1rp6K+4eCHJk/0F3J0xu5VKvLQmFIgkLpfmL7ryxxkx4 URRIGG83uV5mUB6qXdWP3Jw+2n//0FjeMvYA/c+4yqVLQpgGCif2LEvyRPdASjXsd930 SvXfNdHFlxiXUGy3bdUe+2WdzQ4/YNFuXgDGELjvYQb/Yo9KvMjcOJB1LZN+YrLOkX3R wsBqV08kTXCd415BhshxTjEhoslwvpxG/1WsFPg7V6MN6almS3DgsGtPsZ+Jh3cFiNLP PJew== X-Gm-Message-State: AFeK/H167yNd1st6Fhg32dLF18Avcnq3Sy9Y1jFR7Tqb2jP0qxSfuU/d SaRkq3LsFV68p2f3S0ulPFZzjUf8gjPa X-Received: by 10.36.0.198 with SMTP id 189mr14994110ita.82.1491314034738; Tue, 04 Apr 2017 06:53:54 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.30.209 with HTTP; Tue, 4 Apr 2017 06:53:34 -0700 (PDT) In-Reply-To: References: <201704032316.v33NGpbo037305@repo.freebsd.org> <4ceb1a18-3a72-c0e3-b2e2-f71d687cd153@freebsd.org> <9018c8db-2a89-c8b2-750b-fe11ac08333f@freebsd.org> From: Ed Maste Date: Tue, 4 Apr 2017 09:53:34 -0400 X-Google-Sender-Auth: 5z5V68MdYEF9cNkwoidFgGAvtmQ Message-ID: Subject: Re: svn commit: r316477 - head/usr.bin/grep To: Kyle Evans Cc: Andrey Chernov , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 13:53:55 -0000 On 4 April 2017 at 09:09, Kyle Evans wrote: > > This is where it gets kind of finnicky, and I'll step out and let others > weigh in -- the test I refer to was specifically written by me > (https://reviews.freebsd.org/D10112), and it's entirely to make it easier > for me to check and quantify to others where we're actually regressing or > improving as I continue fixing things in bsdgrep(1). In this case I'd rather we remove the 00 and have the test verify that. I think it's fine if there are a few tests that fail when run with GNU grep where it has the undesired, differing behaviour.