Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Jul 2019 14:59:33 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 239334] mail/milter-greylist bring GeoIP support back, utilizing libmaxminddb implemented by Markus Wennrich
Message-ID:  <bug-239334-7788-NU3ct6BNKw@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-239334-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-239334-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D239334

--- Comment #2 from Harald Schmalzbauer <bugzilla.freebsd@omnilan.de> ---
Hello,

haven't included that change since up to now, there was a configure-patch in
place, instead of autoreconf.
I'll add a diff for switching to autoreconf additionally, which reduces
files/patch-libmaxminddb-support_from_GH-geoip2-fork significantly and remo=
ves
files/patch-configure.

I have no idea about yacc and bison, hence no idea about the corresponding
hunks in the diff, please check if it's correct what Markus Wennrich provid=
es.

I also don't know if
MAXMINDDB_DESC=3D         Enable GeoIP1 + GeoIP2 Support
is correct.
I copied from a different port.  I assumed the author is right, but accordi=
ng
to https://maxmind.github.io/libmaxminddb/ he isn't, if I interpret the
description of "typedef struct MMDB_metadata_s" correctly, where we can read
=C2=BBThe binary_format_major_version should always be 2=C2=AB.  Please cor=
rect this
before commiting.  I just randomly chose one port listed in
https://svnweb.freebsd.org/ports?view=3Drevision&revision=3D490211, which a=
lso
needs finxing in case really is incorrect.

Again, if this patch isn't an immediate solution for you, please revert
r490200.
The GeoIP option removal badly breaks existing setups, which must not happen
for this kind of reason/event/problem (the discontinuance of upstream updat=
es).

Thanks,
-harry

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-239334-7788-NU3ct6BNKw>