From nobody Tue Mar 24 10:39:01 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fg6396qX9z6WTrq for ; Tue, 24 Mar 2026 10:39:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fg6394JFFz3trD for ; Tue, 24 Mar 2026 10:39:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774348741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=se7DFOKituQ1/peRn6t7NpnzFjfxGevWexBGjDCNE54=; b=qJXTS45TmHM6GBDimlpELbBM/uFIjjYi1h0p8nVBPZS1gOx7+4zZoiavXzI21eaC1LnRaw nUn0jkrrokVmx42tsRllcxx4k3jSOB7cblr1DtUfgxELHV9ttgPO1l4RYUgZKweIiOK3dU xCitmGF0Xqwoc4N9AQ3v1aKvR8A+G7xhqKEfxL0XGtC6RQ1i4iVdk/RQMQ4JNo9Zzatr0/ lu3hK4Ut3oUBTST+Rxi3wxrPWqze9l5e1Eu/yuiXy4JT5rb4355d7/FL8yR7IDOyC6RPiA +ojed+tCXXY+jLMhqcLIUE5VUxnqrNQnsaltjimlYY1CDayBhAKwpYwvIElmJg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774348741; a=rsa-sha256; cv=none; b=vKsIB6dXa5Zg2MUG2TNR+okJdxL8X/rmCYU1VySKSw2eXEKNdUkeeSvNl7hshwIrPxu9eN aQJaJJFIrQV/TceZy77gtOL+bUY6BMNMTVzH0kevIDB/w+a+Ib/L/BIp5W53OB8G2zug1h kBrk6ve5zkgtaDcwUwFw9SYaLLzcnX0+a9O9UjM+edwJ1eG0gkD79wjST7Z+3c5qFwj4nw NT5/8wM22xupYPxgGSSxTAiZlcfPj/TeoPzkuVsRsRpzqlq0Ax22jyJfUKSXof+rR96kBR EZExhSmIt8d9EPuqCu++jGXc6I2Dr3RGfX0vcDR7JnFhUqnE66p2CYtJyPsXXg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774348741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=se7DFOKituQ1/peRn6t7NpnzFjfxGevWexBGjDCNE54=; b=I4sJIRHZkaMCQ0lFSh9ilRvoDzhCyGNc9zgkrjOpkaOBOnvSGf6UV4Z2uQLmD4O+NNF0Ao 06nzmZSpPCEJdEbeuh1Go4ehlfbE3bvkjnenXQOouljFCcUcRnqjbVDbaRCn1xWA/ojwV7 CLXmLtsdUawmZOR/EsgturzPWjNuwiQFIQ+i+cZA6qFvNz7uVAwFSJYpw9L6K8jjtskxER /cXZTygawpOYWkXI+Lw65dYLOwydr8G/ld8K7TnNczSCnsisa483oycs5E7bOqNaJNhlam D9cMjiAF78NghVLk9cJZxHcTj8S7tyRWONTvuYBM3BPpbqDLXDrs2PINGNZt9A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fg6393FxTzn3 for ; Tue, 24 Mar 2026 10:39:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32455 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 24 Mar 2026 10:39:01 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 4324e0fa71f8 - main - sound: Remove SND_DIAGNOSTIC section in buffer.c List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4324e0fa71f85f274013100d912584a042c9909e Auto-Submitted: auto-generated Date: Tue, 24 Mar 2026 10:39:01 +0000 Message-Id: <69c269c5.32455.45b18ca3@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=4324e0fa71f85f274013100d912584a042c9909e commit 4324e0fa71f85f274013100d912584a042c9909e Author: Christos Margiolis AuthorDate: 2026-03-24 10:31:48 +0000 Commit: Christos Margiolis CommitDate: 2026-03-24 10:38:41 +0000 sound: Remove SND_DIAGNOSTIC section in buffer.c The purpose of this has not been documented, but it seems like it makes it possible to view the maximum number of bytes that passed to sndbuf_feed(), as well as the maximum number of cycles taken inside its main loop. These do not seem particularly useful anymore. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D55989 --- sys/dev/sound/pcm/buffer.c | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/sys/dev/sound/pcm/buffer.c b/sys/dev/sound/pcm/buffer.c index 1db9e5661dc8..0c574ae2908c 100644 --- a/sys/dev/sound/pcm/buffer.c +++ b/sys/dev/sound/pcm/buffer.c @@ -506,29 +506,11 @@ sndbuf_dispose(struct snd_dbuf *b, u_int8_t *to, unsigned int count) return 0; } -#ifdef SND_DIAGNOSTIC -static uint32_t snd_feeder_maxfeed = 0; -SYSCTL_UINT(_hw_snd, OID_AUTO, feeder_maxfeed, CTLFLAG_RD, - &snd_feeder_maxfeed, 0, "maximum feeder count request"); - -static uint32_t snd_feeder_maxcycle = 0; -SYSCTL_UINT(_hw_snd, OID_AUTO, feeder_maxcycle, CTLFLAG_RD, - &snd_feeder_maxcycle, 0, "maximum feeder cycle"); -#endif - /* count is number of bytes we want added to destination buffer */ int sndbuf_feed(struct snd_dbuf *from, struct snd_dbuf *to, struct pcm_channel *channel, struct pcm_feeder *feeder, unsigned int count) { unsigned int cnt, maxfeed; -#ifdef SND_DIAGNOSTIC - unsigned int cycle; - - if (count > snd_feeder_maxfeed) - snd_feeder_maxfeed = count; - - cycle = 0; -#endif KASSERT(count > 0, ("can't feed 0 bytes")); @@ -544,16 +526,8 @@ sndbuf_feed(struct snd_dbuf *from, struct snd_dbuf *to, struct pcm_channel *chan break; sndbuf_acquire(to, to->tmpbuf, cnt); count -= cnt; -#ifdef SND_DIAGNOSTIC - cycle++; -#endif } while (count != 0); -#ifdef SND_DIAGNOSTIC - if (cycle > snd_feeder_maxcycle) - snd_feeder_maxcycle = cycle; -#endif - return (0); }