Date: Tue, 2 Aug 2016 16:52:45 +0200 From: Guido Falsi <mad@madpilot.net> To: Mateusz Guzik <mjguzik@gmail.com>, Michael Butler <imb@protected-networks.net>, freebsd-current <freebsd-current@freebsd.org> Subject: Re: SVN r303643 breaks non-SMP compilation Message-ID: <f9190248-23a8-ea0c-041a-364f8cfeee2b@madpilot.net> In-Reply-To: <20160802030624.GA24961@dft-labs.eu> References: <6a9f68a7-8b1c-92cd-1409-fe574602a005@protected-networks.net> <20160802030624.GA24961@dft-labs.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08/02/16 05:06, Mateusz Guzik wrote: > On Mon, Aug 01, 2016 at 09:49:03PM -0400, Michael Butler wrote: >> In the non-SMP case, ADAPTIVE_MUTEXES is not defined and a subsequent >> reference to mtx_delay causes compilation of kern_mutex.c to fail >> because KDTRACE_HOOKS may be, >> > > Indeed, fixed in r303655. > > Thanks for reporting. > I've noticed another failure in the same file, caused by r303643. It's failing to compile here due to errors about SYSINIT(9), it looks like #include <sys/kernel.h> is missing. I have made a local patch which compiles and afdter a reboot seems to work fine: Index: head/sys/kern/kern_sx.c =================================================================== --- head/sys/kern/kern_sx.c (revision 303658) +++ head/sys/kern/kern_sx.c (working copy) @@ -58,6 +58,7 @@ #if defined(SMP) && !defined(NO_ADAPTIVE_SX) #include <machine/cpu.h> +#include <sys/kernel.h> #endif #ifdef DDB -- Guido Falsi <mad@madpilot.net>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f9190248-23a8-ea0c-041a-364f8cfeee2b>