Date: Wed, 11 Jan 2012 16:23:48 +0000 From: Matthew Seaman <m.seaman@infracaninophile.co.uk> To: freebsd-ports@freebsd.org Subject: Re: linux-f10-nss_ldap: my first port - be gentle :) Message-ID: <4F0DB794.7000600@infracaninophile.co.uk> In-Reply-To: <CAF6rxgmYfKm=qYJXJfAJniyuxA1jm6zX=m9KP9YBqCmmse8ykQ@mail.gmail.com> References: <4F0446B7.4090703@herveybayaustralia.com.au> <20120104142757.1c77c347@ernst.jennejohn.org> <4F04E648.9090206@herveybayaustralia.com.au> <20120105121825.656677e4@ernst.jennejohn.org> <20120106221610.00005fbe@unknown> <CADLo83-YUtUgAw_r2QNpB2mPxbvPfV0vCRMih-ncAQBCWj73LQ@mail.gmail.com> <20120108160316.00003d59@unknown> <4F0A8164.9090502@herveybayaustralia.com.au> <20120110221115.00007dc1@unknown> <4F0CDB5B.9030402@herveybayaustralia.com.au> <EBA4CEA9D06CDF6C3E6F5095@utd71538.utdallas.edu> <CAF6rxgmYfKm=qYJXJfAJniyuxA1jm6zX=m9KP9YBqCmmse8ykQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigD7CE31D95C45E52DF18CE23D
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
On 11/01/2012 16:10, Eitan Adler wrote:
>>> post-extract:
>>> >> .if defined(WITH_PAM)
>>> >> PLIST_FILES+=3Dlib/security/pam_ldap.so
>>> >>
>>> >>
>>> >> .else
>>> >> @if [ -f ${WRKDIR}/lib/security/pam_ldap.so ];=
then \
>>> >> ${RM} ${WRKDIR}/lib/security/pam_ldap.so
>>> >> ${DIRRM} ${WRKDIR}/lib/;
>>> >> fi
>> >
>> > ^^^^^
>> > This is what's wrong. In port Makefiles, it's .if, .else, .endif no=
t fi.
> You need both: .endif and fi in this case (the 'fi' is part of the shel=
l script)
Also the shell script part needs to be backslashed, and statements
separated by semi-colons, like so:
@if [ -f ${WRKDIR}/lib/security/pam_ldap.so ]; then \
${RM} ${WRKDIR}/lib/security/pam_ldap.so ; \
${DIRRM} ${WRKDIR}/lib/ ; \
fi
Looking back at the OP's previous posts, it's this backslashing thing
which is missing: the (make) .if is properly closed with a .endif, which
unfortunately got cropped in one of the replies upthread.
Another point: its not usual to modify variables like PLIST_FILES or
PORTDOCS as part of the post-extract target. Usually that's done
earlier in the Makefile before any of the actual make targets.
Cheers,
Matthew
--=20
Dr Matthew J Seaman MA, D.Phil. 7 Priory Courtyard
Flat 3
PGP: http://www.infracaninophile.co.uk/pgpkey Ramsgate
JID: matthew@infracaninophile.co.uk Kent, CT11 9PW
--------------enigD7CE31D95C45E52DF18CE23D
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk8Nt5sACgkQ8Mjk52CukIwJIgCeOmIV3Uo6as3sAbXmToO4J+T8
tGAAn15b/k2IVCx2rLYdZvUx+pHKsG1T
=hlb2
-----END PGP SIGNATURE-----
--------------enigD7CE31D95C45E52DF18CE23D--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F0DB794.7000600>