From owner-cvs-src-old@FreeBSD.ORG  Fri Aug 28 22:31:12 2009
Return-Path: <owner-cvs-src-old@FreeBSD.ORG>
Delivered-To: cvs-src-old@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1692C10656C0
	for <cvs-src-old@freebsd.org>; Fri, 28 Aug 2009 22:31:12 +0000 (UTC)
	(envelope-from zec@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 049838FC13
	for <cvs-src-old@freebsd.org>; Fri, 28 Aug 2009 22:31:12 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n7SMVBcc088054
	for <cvs-src-old@freebsd.org>; Fri, 28 Aug 2009 22:31:11 GMT
	(envelope-from zec@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n7SMVBY3088053
	for cvs-src-old@freebsd.org; Fri, 28 Aug 2009 22:31:11 GMT
	(envelope-from zec@repoman.freebsd.org)
Message-Id: <200908282231.n7SMVBY3088053@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	zec@repoman.freebsd.org using -f
From: Marko Zec <zec@FreeBSD.org>
Date: Fri, 28 Aug 2009 22:30:55 +0000 (UTC)
To: cvs-src-old@freebsd.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/net vnet.c
X-BeenThere: cvs-src-old@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the src tree
	<cvs-src-old.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src-old>
List-Post: <mailto:cvs-src-old@freebsd.org>
List-Help: <mailto:cvs-src-old-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Aug 2009 22:31:12 -0000

zec         2009-08-28 22:30:55 UTC

  FreeBSD src repository

  Modified files:
    sys/net              vnet.c 
  Log:
  SVN rev 196633 on 2009-08-28 22:30:55Z by zec
  
  Introduce a separate sx lock for protecting lists of vnet sysinit
  and sysuninit handlers.
  
  Previously, sx_vnet, which is a lock designated for protecting
  the vnet list, was (ab)used for protecting vnet sysinit / sysuninit
  handler lists as well.  Holding exclusively the sx_vnet lock while
  invoking sysinit and / or sysuninit handlers turned out to be
  problematic, since some of the handlers may attempt to wake up
  another thread and wait for it to walk over the vnet list, hence
  acquire a shared lock on sx_vnet, which in turn leads to a deadlock.
  Protecting vnet sysinit / sysuninit lists with a separate lock
  mitigates this issue, which was first observed with
  flowtable_flush() / flowtable_cleaner() in sys/net/flowtable.c.
  
  Reviewed by:    rwatson, jhb
  MFC after:      3 days
  
  Revision  Changes    Path
  1.10      +26 -20    src/sys/net/vnet.c