From owner-svn-src-all@FreeBSD.ORG  Tue Jul  8 12:57:13 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3D6A8D67;
 Tue,  8 Jul 2014 12:57:13 +0000 (UTC)
Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214])
 (using TLSv1.1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id EDE0A2F78;
 Tue,  8 Jul 2014 12:57:12 +0000 (UTC)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 5A7FE1FE028;
 Tue,  8 Jul 2014 14:57:02 +0200 (CEST)
Message-ID: <53BBEAA6.8090006@selasky.org>
Date: Tue, 08 Jul 2014 14:57:10 +0200
From: Hans Petter Selasky <hps@selasky.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: Marius Strobl <marius@alchemy.franken.de>
Subject: Re: svn commit: r268354 - head/sys/dev/usb/controller
References: <201407070517.s675HHr9048970@svn.freebsd.org>
 <20140708104900.GG7615@alchemy.franken.de>
In-Reply-To: <20140708104900.GG7615@alchemy.franken.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jul 2014 12:57:13 -0000

On 07/08/14 12:49, Marius Strobl wrote:
> On Mon, Jul 07, 2014 at 05:17:17AM +0000, Hans Petter Selasky wrote:
>> Author: hselasky
>> Date: Mon Jul  7 05:17:16 2014
>> New Revision: 268354
>> URL: http://svnweb.freebsd.org/changeset/base/268354
>>
>> Log:
>>    Improve support for Intel Lynx Point USB 3.0 controllers by masking
>>    the port routing bits like done in Linux.
>>
>>    MFC after:	1 week
>>    Tested by:	Tur-Wei Chan <twchan@singnet.com.sg>
>>
>> Modified:
>>    head/sys/dev/usb/controller/xhci_pci.c
>>    head/sys/dev/usb/controller/xhcireg.h
>>
>> Modified: head/sys/dev/usb/controller/xhci_pci.c
>> ==============================================================================
>> --- head/sys/dev/usb/controller/xhci_pci.c	Mon Jul  7 03:10:56 2014	(r268353)
>> +++ head/sys/dev/usb/controller/xhci_pci.c	Mon Jul  7 05:17:16 2014	(r268354)
>> @@ -157,6 +157,9 @@ xhci_pci_port_route(device_t self, uint3
>>   	temp |= set;
>>   	temp &= ~clear;
>>
>> +	/* Don't set bits which the hardware doesn't support */
>> +	temp &= pci_read_config(self, PCI_XHCI_INTEL_USB3PRM, 4);
>> +
>>   	pci_write_config(self, PCI_XHCI_INTEL_USB3_PSSEN, temp, 4);
>>   	pci_write_config(self, PCI_XHCI_INTEL_XUSB2PR, temp, 4);
>>
>
> Is there a reason you only exclude ports that PCI_XHCI_INTEL_USB3PRM
> reports as not switchable to SuperSpeed, but not also ports that the
> hardware reports as not routable between the EHCI and xHCI controller
> via PCI_XHCI_INTEL_USB2PRM (as Linux does, which might be wront,
> though)?
>

No specific reason. Feel free to experiment.

--HPS