From owner-svn-src-head@freebsd.org Tue Mar 29 20:18:22 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C73E4AE20A0; Tue, 29 Mar 2016 20:18:22 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-lb0-x22b.google.com (mail-lb0-x22b.google.com [IPv6:2a00:1450:4010:c04::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48DC81A96; Tue, 29 Mar 2016 20:18:22 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-lb0-x22b.google.com with SMTP id vo2so18439267lbb.1; Tue, 29 Mar 2016 13:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-transfer-encoding; bh=SqPmTBJYSX/Ir1udClIPl5Kf7Qo7UGKD8xY8mxjdGs0=; b=FUtyzBjkjPrAQygjO+L1gCO0pez0Qpxg5nlayF3kziPl6m1gnCbtUQ4gEh3Hsq+PIA gOde3Uden00pi4Gh5M591rO/JlqalMSWCpEaHCGlTgpUj8q+wYM5p+58Ss4YVG24ua19 mE9KjgzF5cbcIrGU2DpWHdAdscJum+RpC28dKFWtRMftzQNFFODLaPkzRAMFpN9J8qK9 J6TJUyLB8/4isjJamLZxBdY+e9ZhCnDQQ3p5jPan1cKPIvXCKq1HvqvqjT5bz+1HmOLJ j8pgCyaYUrdQvTbX+czqZN+u+LvgAIG2kSD8f1BRgfzuELVmJ90B/DDTToXoF/n+AV2g C9xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:message-id:date:from:user-agent :mime-version:to:subject:references:in-reply-to :content-transfer-encoding; bh=SqPmTBJYSX/Ir1udClIPl5Kf7Qo7UGKD8xY8mxjdGs0=; b=geYF6eTDTvkqqAcsKhfZ4uHjvUrXkl16KxbWa01y6abV1YSPARys+N66rfpY/BsEe2 GhPxIkvwqEIu097oTg+wZkgN3G3CAdU2zNMNyrGs8Bb188XEwbrbK4/JMeJyAgcRnJxN S3vjko9S2Jy3473UNZHk/oW4K1uD2EteXcdjxbiUskpZd6t4TlVDIZ/COV7iCM8y63vS Ju1lb2VETNe0bws5ffMjG5fQyrrNJc/azVgRrfhETlFL9XspdDxI4jTSZeaOATG3Qhn2 v8TLGywro19thSVaHHYK292Fzj+cV5sHwb7skMY2f8H4qh0jN0klJASDDlz97r4MKeLl sv9Q== X-Gm-Message-State: AD7BkJK9gvsZ3FR6F66k0DDweVxJs3DuYAaAHT1YC8hWA0yxoDtOKQdDo8BQIX5QRa3laA== X-Received: by 10.112.25.99 with SMTP id b3mr1998431lbg.11.1459282700624; Tue, 29 Mar 2016 13:18:20 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([134.249.139.101]) by smtp.googlemail.com with ESMTPSA id ai2sm54341lbc.46.2016.03.29.13.18.19 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 29 Mar 2016 13:18:20 -0700 (PDT) Sender: Alexander Motin Message-ID: <56FAE30A.2080300@FreeBSD.org> Date: Tue, 29 Mar 2016 23:18:18 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Andriy Gapon , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r297396 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs References: <201603291918.u2TJIYRp024552@repo.freebsd.org> <56FADFE8.6040203@FreeBSD.org> In-Reply-To: <56FADFE8.6040203@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2016 20:18:22 -0000 On 29.03.16 23:04, Andriy Gapon wrote: > On 29/03/2016 22:18, Alexander Motin wrote: >> Author: mav >> Date: Tue Mar 29 19:18:34 2016 >> New Revision: 297396 >> URL: https://svnweb.freebsd.org/changeset/base/297396 >> >> Log: >> Modify "4958 zdb trips assert on pools with ashift >= 0xe". >> >> Unlike Illumos FreeBSD has concept of logical ashift, that specifies >> really minimal vdev block size that can be accessed. This knowledge >> allows properly pad physical I/O and correctly assert its alignment. >> >> This change fixes L2ARC write errors when device has logical sector >> size above 512 bytes. >> >> MFC after: 1 month > > Alexander, > > I believe that this is wrong. > We must not modify any parameters of a physical zio including its size. > Otherwise we are going to overwrite something that an originator of the I/O did > not intend to overwrite. Here we should have a check (or just the assertion) > that the zio conforms to disk characteristics. It's the code that creates > physical zio-s that should be made aware of the alignment requirements. Generally I agree with your point. I also had such thoughts. Though this way is much easier and less invasive and I can not find any real failure scenario for it. I will happily revert it when better solution is ready. > Please see my work in this direction: https://reviews.freebsd.org/D2789 > (BTW, I added you as a reviewer there). Sure. I'll take a look on that. -- Alexander Motin