From nobody Tue Feb 3 14:39:39 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f55jR3g8bz6Pf7c for ; Tue, 03 Feb 2026 14:39:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f55jR2SJvz3s7N for ; Tue, 03 Feb 2026 14:39:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770129579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8nLOPp4OkZ2H5lgScNW1PJt7PMYJ1/s75qNiForGkE4=; b=eirovhsvk8ikPcxzs/sOeveT36vEh71WEpoSTZoJmyKFu103y1CegMS5vvUTHbgQOiKDmf Fqlo6w6xn/yT512wUqAGiofiYG8NzHXUnev63ebx6VLI1ZagRiHFgUZMA305j8S1xzOzCs 4KQn6tHsqiMhbc/Siaa8ppeAAhLpi0cT5/zMDLmxz6pZsrECR55juybIhXffKix5bUNZDh 9cFZ+D0InTeB/tUuSj5yp5J3xoedpz390/X3qYqA2+uVD6jNRcogxZLe2p+Dgn2WT7Ox+o IKlw/u7Uuenv4Iza7bKP9GWNeZLoaCAe9BNn/wCaggRciffw87v8GoDE6jzh2w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770129579; a=rsa-sha256; cv=none; b=Hc8Sys8juTb/545WzHL6aV6rfz3zG+9FrlxZ4osEtXYrJtpdselsaU2kGymCdhp6hazQaG spC5P2Ogn7fD/IbkDWUXXRBrexcD/jI07jyke7kD6MFD43EaZPRCZwayatMxf9uyzyKGLF 53dRIASkD/q6p3tC872mle4v2rSW2R787EGt438SkbHWRivM+UctieJ1wSeaLiwkV5f190 Es2wFk9fa+f8r6OlkJASdZtL/eCBN1eSJZ4zxCSofHWJPs6cTBS6kgaWibkLvAkeVH3NKK mEboM9jibt82KHD3maUw8sIpb4MeJJVxSRlhyLfHGt8Jh+HWFxVngE2dn0h+Zg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770129579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8nLOPp4OkZ2H5lgScNW1PJt7PMYJ1/s75qNiForGkE4=; b=fMvGkbRHlJGJuJqYTC0oESliew9Xw4JuN80Q6ihq8FUD8S7wRtLAiLVgGXQI8xvBOKelBR rT7jZ21pgJWnmqioCX203LmqHryBeG5134aodMOy9zz1bqqkY52pmL2VSu5hXt+PykumDg Zv8Otb7DHQK8vsheFwLBCgKl+xI3Pi3sQWxhqDxxdTNQ2i3ztS5U5wmodMR8vd3RsFI8hM 5tfsCqyjuttv7zSUof0KEfYxLKmVI2y2TR+VtXi2fufMYh1xgaKPrBXw9BskVbV7Y73L3x TVRo5juNQqoeqXnZLeuCqt/ahR0Z2tKFeFZsdZ8Myb+Gx/KdEaXUBAo6/DFI1Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f55jR1qWQz2Sk for ; Tue, 03 Feb 2026 14:39:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ba73 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 03 Feb 2026 14:39:39 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: d70b9eb74fc4 - main - libc/tests: Clean up *dir() tests List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d70b9eb74fc4aa430bd2ff4bca37e6a9b6c8004f Auto-Submitted: auto-generated Date: Tue, 03 Feb 2026 14:39:39 +0000 Message-Id: <698208ab.3ba73.5a401c8e@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=d70b9eb74fc4aa430bd2ff4bca37e6a9b6c8004f commit d70b9eb74fc4aa430bd2ff4bca37e6a9b6c8004f Author: Dag-Erling Smørgrav AuthorDate: 2026-02-03 14:39:21 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-03 14:39:32 +0000 libc/tests: Clean up *dir() tests Mainly, avoid reusing the name of one of the functions we should be testing (but aren't) for local variables. Sponsored by: Klara, Inc. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D55054 --- lib/libc/tests/gen/dir2_test.c | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/lib/libc/tests/gen/dir2_test.c b/lib/libc/tests/gen/dir2_test.c index 4ec5a1759d06..dac8ccbe472a 100644 --- a/lib/libc/tests/gen/dir2_test.c +++ b/lib/libc/tests/gen/dir2_test.c @@ -41,7 +41,6 @@ ATF_TC(telldir_after_seekdir); ATF_TC_HEAD(telldir_after_seekdir, tc) { - atf_tc_set_md_var(tc, "descr", "Calling telldir(3) after seekdir(3) " "should return the argument passed to seekdir."); } @@ -50,7 +49,7 @@ ATF_TC_BODY(telldir_after_seekdir, tc) const int NUMFILES = 1000; char template[] = "dXXXXXX"; char *tmpdir; - int i, dirfd; + int i, dd; DIR *dirp; struct dirent *de; long beginning, middle, end, td; @@ -58,8 +57,8 @@ ATF_TC_BODY(telldir_after_seekdir, tc) /* Create a temporary directory */ tmpdir = mkdtemp(template); ATF_REQUIRE_MSG(tmpdir != NULL, "mkdtemp failed"); - dirfd = open(tmpdir, O_RDONLY | O_DIRECTORY); - ATF_REQUIRE(dirfd > 0); + dd = open(tmpdir, O_RDONLY | O_DIRECTORY); + ATF_REQUIRE(dd > 0); /* * Fill it with files. Must be > 128 to ensure that the directory @@ -70,14 +69,14 @@ ATF_TC_BODY(telldir_after_seekdir, tc) char filename[16]; snprintf(filename, sizeof(filename), "%d", i); - fd = openat(dirfd, filename, O_WRONLY | O_CREAT, 0600); + fd = openat(dd, filename, O_WRONLY | O_CREAT, 0600); ATF_REQUIRE(fd > 0); close(fd); } /* Get some directory bookmarks in various locations */ - dirp = fdopendir(dirfd); - ATF_REQUIRE_MSG(dirfd >= 0, "fdopendir failed"); + dirp = fdopendir(dd); + ATF_REQUIRE_MSG(dd >= 0, "fdopendir failed"); beginning = telldir(dirp); for (i = 0; i < NUMFILES / 2; i = i+1) { de = readdir(dirp); @@ -126,7 +125,7 @@ ATF_TC_BODY(telldir_at_end_of_block, tc) const int NUMFILES = 129; char template[] = "dXXXXXX"; char *tmpdir; - int i, dirfd; + int i, dd; DIR *dirp; struct dirent *de; long td; @@ -135,8 +134,8 @@ ATF_TC_BODY(telldir_at_end_of_block, tc) /* Create a temporary directory */ tmpdir = mkdtemp(template); ATF_REQUIRE_MSG(tmpdir != NULL, "mkdtemp failed"); - dirfd = open(tmpdir, O_RDONLY | O_DIRECTORY); - ATF_REQUIRE(dirfd > 0); + dd = open(tmpdir, O_RDONLY | O_DIRECTORY); + ATF_REQUIRE(dd > 0); /* * Fill it with files. Must be > 128 to ensure that the directory @@ -147,14 +146,14 @@ ATF_TC_BODY(telldir_at_end_of_block, tc) char filename[16]; snprintf(filename, sizeof(filename), "%d", i); - fd = openat(dirfd, filename, O_WRONLY | O_CREAT, 0600); + fd = openat(dd, filename, O_WRONLY | O_CREAT, 0600); ATF_REQUIRE(fd > 0); close(fd); } /* Read all entries within the first page */ - dirp = fdopendir(dirfd); - ATF_REQUIRE_MSG(dirfd >= 0, "fdopendir failed"); + dirp = fdopendir(dd); + ATF_REQUIRE_MSG(dd >= 0, "fdopendir failed"); for (i = 0; i < NUMFILES - 1; i = i + 1) ATF_REQUIRE_MSG(readdir(dirp) != NULL, "readdir failed"); @@ -178,9 +177,8 @@ ATF_TC_BODY(telldir_at_end_of_block, tc) ATF_TP_ADD_TCS(tp) { - ATF_TP_ADD_TC(tp, telldir_after_seekdir); ATF_TP_ADD_TC(tp, telldir_at_end_of_block); - return atf_no_error(); + return (atf_no_error()); }