Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 Oct 2021 08:13:38 +0200
From:      Mateusz Piotrowski <0mp@FreeBSD.org>
To:        "Vanilla I. Shu" <vanilla@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: e59e69659a1f - main - net/dpdk-20.11: add port.
Message-ID:  <f7adc166-b21b-117f-93ed-14ad83799c80@FreeBSD.org>
In-Reply-To: <202110140730.19E7UfRm047044@gitrepo.freebsd.org>
References:  <202110140730.19E7UfRm047044@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi!
On 14/10/2021 09:30, Vanilla I. Shu wrote:
> The branch main has been updated by vanilla:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=3De59e69659a1f1f7c2c3f43=
5b889042499a5c5f70
>
> commit e59e69659a1f1f7c2c3f435b889042499a5c5f70
> Author:     Vanilla I. Shu <vanilla@FreeBSD.org>
> AuthorDate: 2021-10-14 07:17:48 +0000
> Commit:     Vanilla I. Shu <vanilla@FreeBSD.org>
> CommitDate: 2021-10-14 07:29:42 +0000
>
>      net/dpdk-20.11: add port.
>     =20
>      PR:             254402
>      Reported by:    Bruce Richardson <bruce.richardson at intel.com>
> ---

> diff --git a/net/dpdk-20.11/Makefile b/net/dpdk-20.11/Makefile
> new file mode 100644
> index 000000000000..f8d598a1814d
> --- /dev/null
> +++ b/net/dpdk-20.11/Makefile
> @@ -0,0 +1,51 @@
> +# $FreeBSD$
This is not necessary anymore.
> +
> +PORTNAME=3D	dpdk
> +DISTVERSION=3D	20.11.1
> +CATEGORIES=3D	net
> +MASTER_SITES=3D	http://fast.dpdk.org/rel/
> +PKGNAMESUFFIX=3D	20.11
Could it be that we wanted to have "-20.11" here instead to match the por=
t origin?
> +
> +MAINTAINER=3D	bruce.richardson@intel.com
> +COMMENT=3D	DPDK: Software libraries for packet processing
COMMENT should not contain the name of the software

Also, take a look at the linters available as ports-mgmt/portfmt. They ar=
e quite amazing at sorting=20
variables in a makefile and formatting it nicely.

Cheers!

Mateusz Piotrowski





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f7adc166-b21b-117f-93ed-14ad83799c80>