From owner-freebsd-ports Tue Dec 5 0:54:57 2000 From owner-freebsd-ports@FreeBSD.ORG Tue Dec 5 00:54:55 2000 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from blizzard.sabbo.net (blizzard.sabbo.net [193.193.218.18]) by hub.freebsd.org (Postfix) with ESMTP id 9C69137B400; Tue, 5 Dec 2000 00:54:47 -0800 (PST) Received: from vic.sabbo.net (root@vic.sabbo.net [193.193.218.109]) by blizzard.sabbo.net (8.10.1/8.10.1) with ESMTP id eB59uOC01194; Tue, 5 Dec 2000 11:56:34 +0200 Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vic.sabbo.net (8.11.1/8.9.3) with ESMTP id eB58sRv42740; Tue, 5 Dec 2000 10:54:27 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Message-ID: <3A2CAD41.39793C0A@FreeBSD.org> Date: Tue, 05 Dec 2000 10:54:26 +0200 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.76 [en] (WinNT; U) X-Accept-Language: uk,ru,en MIME-Version: 1.0 To: mharo@FreeBSD.org Cc: Akinori MUSHA , FreeBSD-ports Subject: Re: portlint update References: <86u28kwghs.wl@archon.local.idaemons.org> <3A2B895D.D67E403A@FreeBSD.org> <86sno4w5g6.wl@archon.local.idaemons.org> <3A2BBF80.9CC69A1E@FreeBSD.org> <20001204104216.A44022@FreeBSD.org> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Michael Haro wrote: > On Mon, Dec 04, 2000 at 06:00:00PM +0200, Maxim Sobolev wrote: > > > Maybe it would be better to add MASTER_SITES_ALL variable into bsd.sites.mk, which will contain all MASTER_SITE_*? Then it could be easily > > dumped with make -V MASTER_SITES_ALL, thus eliminating the need for parsing bsd.sites.mk directly. > > > > -Maxim > > > > With a MASTER_SITES_ALL variable portlint wouldn't be able to recommend > a fix, just detect a problem. > > I think parsing bsd.sites.mk is probably better. Huh, it seems that I did not properly describe my proposal. What I'm proposing is to add new variable, say MASTER_SITES_ALL, which will contain *names* of individual MASTER_SITE_* variables, i.e. MASTER_SITES_ALL= MASTER_SITE_FOO MASTER_SITE_BAR ... Then portlint will be able to get names of those variables by quering make -V MASTER_SITES_ALL and query each indivudual variable using make -V ... . This should help in situation, when some of MASTER_SITE_* defined as a superset of some other MASTER_SITE_* (for example currently MASTER_SITE_XFREE and several other defined based on MASTER_SITE_RINGSERVER). -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message