From owner-svn-ports-head@freebsd.org Sun Nov 4 15:13:16 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3158C10DA02E; Sun, 4 Nov 2018 15:13:16 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B52EE75D21; Sun, 4 Nov 2018 15:13:15 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 9DD6DAF7C; Sun, 4 Nov 2018 15:13:15 +0000 (UTC) Date: Sun, 4 Nov 2018 15:13:15 +0000 From: Alexey Dokuchaev To: Rene Ladan Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r484041 - head/devel/heimdall Message-ID: <20181104151315.GA61162@FreeBSD.org> References: <201811041345.wA4DjCGN025777@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201811041345.wA4DjCGN025777@repo.freebsd.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: B52EE75D21 X-Spamd-Result: default: False [-0.90 / 200.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; R_SPF_SOFTFAIL(0.00)[~all]; MX_GOOD(-0.01)[cached: mx66.freebsd.org]; NEURAL_HAM_SHORT(-0.79)[-0.787,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Nov 2018 15:13:16 -0000 On Sun, Nov 04, 2018 at 01:45:12PM +0000, Rene Ladan wrote: > New Revision: 484041 > URL: https://svnweb.freebsd.org/changeset/ports/484041 > > Log: > devel/heimdal1: always use GCC now after removing support for 10.X > > Submitted by: gerald, ehaupt > Approved by: maintainer (ehaupt) > > ... > @@ -15,6 +15,8 @@ LICENSE_FILE= ${WRKSRC}/LICENSE > > USES= cmake > USE_GITHUB= yes > +# does not compile with clang 6.0.0 > +USE_GCC= yes I don't understand, why not just fix the code by removing offending part: --- libpit/source/libpit.h.orig 2017-05-11 18:34:25 UTC +++ libpit/source/libpit.h @@ -25,14 +25,6 @@ #pragma warning(disable : 4996) #endif -#if (!(defined _MSC_VER) || (_MSC_VER < 1700)) - -#ifndef nullptr -#define nullptr 0 -#endif - -#endif - // C/C++ Standard Library #include #include ./danfe