From owner-svn-ports-all@freebsd.org Sat Feb 8 08:23:59 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C3D6623BFAE; Sat, 8 Feb 2020 08:23:59 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48F4vL4Mmqz4Y5B; Sat, 8 Feb 2020 08:23:58 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-ed1-x52b.google.com with SMTP id c26so2197060eds.8; Sat, 08 Feb 2020 00:23:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=dVJ+ZHO1/Ff/deddRaX0IB1VKxkY21LG1S8rJtxtapE=; b=u72/DhydLbbC4DZQPSRlwgT1059UoIZOn6a8sFzjK3Xexbw+m4WRtPjBThLisjCK+e t+gD+qCzx+Cxfo0Ww452+EZOiBikeRptqe2eu77wmbBX3io4hP2qLb8YccEYPx0MiKVJ ZKDO/MEzcSVmHXjs2EdUR4NX/x2UG3lAHH5tkWLVgPZHqbx8QohyeBHOG/zvfOCeHuwm i/F58YSKDA2Nlts/7vLkJYouH9DG3rULl2E5QzXtuDu7inXoq5gbGhMHbih8EQOP4BlJ 6eiKtzl7T/ut6LEba3ydClIb/D/9tXCqhPUekKhR7vqoaXkEnltOmTpUu2B8nfTzSjFW oq9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=dVJ+ZHO1/Ff/deddRaX0IB1VKxkY21LG1S8rJtxtapE=; b=AR5bETxgMBagKtVKKNstrkNE5JORBBzqmh/+pSKKk3wKZg0pTMAi9a+JIu8pLisYi9 6gUrFzOVQKUWEzF41CWTcLtggHsHNO6aMO1WuVg6kLLaAlN5YMacM1ShoT7A4vAVug2c KrXAfQLhd8s7R5E5IuFL/nzDZooOd/qVHr5LJm1cWcR/ibbmgDFZaf4xZZpqPW5LGHgr KSq4gLsQ+bX86KSaaSeiIuEHYdZqszQ+y1cxMU4PYV2jfDrb7odFnb01f/6y5v/S0lYy p7kwxhWRfbIjDAQt+OXxPRtmURl1N241RiL1l/c6f9WQpypybHrycIr/QwjmBM0SW2N2 UkcQ== X-Gm-Message-State: APjAAAXgrV5KGe9mydRmO/EiMCC+Lirm8hK/dnNDINuMDVetDp0S6ggQ vufneHWfs5Ju3kbbWWyg7+XDKV1SlBVPRsxb8+8= X-Google-Smtp-Source: APXvYqw9ZKu12oNXT/NKBVXVhzhi2CKJpvuP5AUe4rdqIFGLcjoeW6bFuA9+G5oHn0BmnuoZi04dBxw+PE6ZnwYBEmA= X-Received: by 2002:a05:6402:61a:: with SMTP id n26mr2458692edv.135.1581150235976; Sat, 08 Feb 2020 00:23:55 -0800 (PST) MIME-Version: 1.0 References: <202002070444.0174iOaP083542@repo.freebsd.org> <98b1bcb9-f2f4-432b-abd3-4885b1cb9de6@Canary> In-Reply-To: Reply-To: araujo@freebsd.org From: Marcelo Araujo Date: Sat, 8 Feb 2020 16:23:43 +0800 Message-ID: Subject: Re: svn commit: r525460 - in head: . sysutils sysutils/uefi-edk2-bhyve sysutils/uefi-edk2-bhyve-devel sysutils/uefi-edk2-bhyve/files To: Rebecca Cran Cc: Dima Panov , Rebecca Cran , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, ports-committers@freebsd.org X-Rspamd-Queue-Id: 48F4vL4Mmqz4Y5B X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=u72/Dhyd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of araujobsdport@gmail.com designates 2a00:1450:4864:20::52b as permitted sender) smtp.mailfrom=araujobsdport@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[araujo@freebsd.org]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[b.2.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-9.49), ipnet: 2a00:1450::/32(-2.49), asn: 15169(-1.74), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Feb 2020 08:23:59 -0000 On Sat, Feb 8, 2020, 12:31 PM Rebecca Cran wrote: > On 2020-02-07 20:56, Dima Panov wrote: > > > Did CSM option was removed by mistake? > Sources still have this knob, -csm slave port still exist, and > bhyve-firmware port still defaults to both variants in depends > > > Yes, it wasn't deliberate. But at the same time, CSM support is broken. So > it might be a few days to a couple of weeks before I debug what's wrong and > come up with a fix. > > Would you like to CSM option fixed in the port beforehand, perhaps with > the csm option marked BROKEN? > You should have tested it better, you even didn't bother to check if other ports depends of this one, and silly me thought you have done it. Revert it would be the best option IMHO. But in other hand as the damage is done already, mark as broken try to fix it as well as your procedures how you test software. It is not the first or second time you break these porta because you don't run enough tests. Cheers, > -- > Rebecca Cran > > >