Date: Sun, 11 Oct 2020 22:51:05 +0200 From: Matthias Andree <mandree@FreeBSD.org> To: Christoph Moench-Tegeder <cmt@burggraben.net> Cc: ports-committers@freebsd.org, gnome <gnome@FreeBSD.org> Subject: Re: svn commit: r552054 - head/x11/gnome-shell Message-ID: <8359bb8b-6276-749b-9807-58488f1b65cb@FreeBSD.org> In-Reply-To: <20201011203426.GA55792@elch.exwg.net> References: <202010111146.09BBkHW0018750@repo.freebsd.org> <20201011203426.GA55792@elch.exwg.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 11.10.20 um 22:34 schrieb Christoph Moench-Tegeder:
> ## Matthias Andree (mandree@FreeBSD.org):
>
>> Log:
>> x11/gnome-shell: complete pkg-plist to fix build issues
>>
>> Approved by: portmgr@ (blanket trivial and tested build-time fix)
>
> I disagree. From poudriere:
> : |Run-time dependency bash-completion found: NO (tried pkgconfig and cmake)
> and
> : pkg-static: Unable to access file /wrkdirs/usr/ports/x11/gnome-shell/work/stage/usr/local/share/bash-completion/completions/gnome-extensions:No such file or directory
>
> Looks like bash-completion is auto-detected and picked up (oh I hate
> that).
Christoph,
I see what I see in the poudriere logs.
Apparently this is how it goes on my computer:
> [00:00:13] [121amd64-svn-job-06] Installing gnome-control-center-3.36.4...
...
> [00:00:40] [121amd64-svn-job-06] `-- Installing cheese-3.38.0_1...
...
> [00:00:55] [121amd64-svn-job-06] | `-- Installing clutter-gtk3-1.8.4...
...
> [00:00:55] [121amd64-svn-job-06] | | `-- Installing gtk3-3.24.23_1...
...
> [00:01:15] [121amd64-svn-job-06] | | `-- Installing cups-2.3.3_1...
...
> [00:01:15] [121amd64-svn-job-06] | | | `-- Installing gnutls-3.6.15...
...
> [00:01:16] [121amd64-svn-job-06] | | | `-- Installing p11-kit-0.23.21...
> [00:01:16] [121amd64-svn-job-06] | | | | `-- Installing bash-completion-2.11,2...
> [00:01:16] [121amd64-svn-job-06] | | | | `-- Installing bash-5.0.18_3...
> [00:01:16] [121amd64-svn-job-06] | | | | `-- Extracting bash-5.0.18_3: .......... done
> [00:01:16] [121amd64-svn-job-06] | | | | `-- Extracting bash-completion-2.11,2: .......... done
So let's take a spade and dig. There is
work/gnome-shell-3.36.6/subprojects/extensions-tool/meson.build
which has
> bash_completion = dependency('bash-completion', required: get_option('bash_completion'))
And there is ports/security/p11-kit/Makefile with
> OPTIONS_DEFINE= BASH DOCS MANPAGES TEST
...
> OPTIONS_DEFAULT= BASH MANPAGES
>
> BASH_BUILD_DEPENDS= bash-completion>=0:shells/bash-completion
> BASH_RUN_DEPENDS= bash-completion>=0:shells/bash-completion
> BASH_MESON_ENABLED= bash_completion
And I also see this in sysutils/gnome-control-center/Makefile:
> OPTIONS_DEFINE= WAYLAND CHEESE
> OPTIONS_DEFAULT=WAYLAND CHEESE
>
> CHEESE_DESC= Cheese webcam support
> CHEESE_LIB_DEPENDS= libcheese.so:multimedia/cheese
> CHEESE_MESON_TRUE= cheese
So unless you are building p11-kit or gnome-control-center with
non-default options, bash-completion will be present (I was testing
poudriere) and be picked up by gnome-shell.
Can it hurt to always include the configuration file? We're talking less
than 2 kB out of 9 MB flat size.
Possibly we may need to enforce its presence.
Regards,
Matthias
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8359bb8b-6276-749b-9807-58488f1b65cb>