From owner-freebsd-gnome@freebsd.org Sun Oct 11 20:51:05 2020 Return-Path: Delivered-To: freebsd-gnome@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9E1E43FCACB for ; Sun, 11 Oct 2020 20:51:05 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4C8Yqs3n1Vz4YtQ for ; Sun, 11 Oct 2020 20:51:05 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 7FEF73FCAC8; Sun, 11 Oct 2020 20:51:05 +0000 (UTC) Delivered-To: gnome@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7FB5D3FC57F for ; Sun, 11 Oct 2020 20:51:05 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C8Yqs2cqZz4Yck; Sun, 11 Oct 2020 20:51:05 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from mandree.no-ip.org (p54a0375b.dip0.t-ipconnect.de [84.160.55.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: mandree/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 1FC4924962; Sun, 11 Oct 2020 20:51:05 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from ryzen.an3e.de (localhost [IPv6:::1]) by ryzen.an3e.de (Postfix) with ESMTP id 9226C120770; Sun, 11 Oct 2020 22:51:05 +0200 (CEST) To: Christoph Moench-Tegeder Cc: ports-committers@freebsd.org, gnome References: <202010111146.09BBkHW0018750@repo.freebsd.org> <20201011203426.GA55792@elch.exwg.net> From: Matthias Andree Subject: Re: svn commit: r552054 - head/x11/gnome-shell Message-ID: <8359bb8b-6276-749b-9807-58488f1b65cb@FreeBSD.org> Date: Sun, 11 Oct 2020 22:51:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20201011203426.GA55792@elch.exwg.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Oct 2020 20:51:05 -0000 Am 11.10.20 um 22:34 schrieb Christoph Moench-Tegeder: > ## Matthias Andree (mandree@FreeBSD.org): > >> Log: >> x11/gnome-shell: complete pkg-plist to fix build issues >> >> Approved by: portmgr@ (blanket trivial and tested build-time fix) > > I disagree. From poudriere: > : |Run-time dependency bash-completion found: NO (tried pkgconfig and cmake) > and > : pkg-static: Unable to access file /wrkdirs/usr/ports/x11/gnome-shell/work/stage/usr/local/share/bash-completion/completions/gnome-extensions:No such file or directory > > Looks like bash-completion is auto-detected and picked up (oh I hate > that). Christoph, I see what I see in the poudriere logs. Apparently this is how it goes on my computer: > [00:00:13] [121amd64-svn-job-06] Installing gnome-control-center-3.36.4... ... > [00:00:40] [121amd64-svn-job-06] `-- Installing cheese-3.38.0_1... ... > [00:00:55] [121amd64-svn-job-06] | `-- Installing clutter-gtk3-1.8.4... ... > [00:00:55] [121amd64-svn-job-06] | | `-- Installing gtk3-3.24.23_1... ... > [00:01:15] [121amd64-svn-job-06] | | `-- Installing cups-2.3.3_1... ... > [00:01:15] [121amd64-svn-job-06] | | | `-- Installing gnutls-3.6.15... ... > [00:01:16] [121amd64-svn-job-06] | | | `-- Installing p11-kit-0.23.21... > [00:01:16] [121amd64-svn-job-06] | | | | `-- Installing bash-completion-2.11,2... > [00:01:16] [121amd64-svn-job-06] | | | | `-- Installing bash-5.0.18_3... > [00:01:16] [121amd64-svn-job-06] | | | | `-- Extracting bash-5.0.18_3: .......... done > [00:01:16] [121amd64-svn-job-06] | | | | `-- Extracting bash-completion-2.11,2: .......... done So let's take a spade and dig. There is work/gnome-shell-3.36.6/subprojects/extensions-tool/meson.build which has > bash_completion = dependency('bash-completion', required: get_option('bash_completion')) And there is ports/security/p11-kit/Makefile with > OPTIONS_DEFINE= BASH DOCS MANPAGES TEST ... > OPTIONS_DEFAULT= BASH MANPAGES > > BASH_BUILD_DEPENDS= bash-completion>=0:shells/bash-completion > BASH_RUN_DEPENDS= bash-completion>=0:shells/bash-completion > BASH_MESON_ENABLED= bash_completion And I also see this in sysutils/gnome-control-center/Makefile: > OPTIONS_DEFINE= WAYLAND CHEESE > OPTIONS_DEFAULT=WAYLAND CHEESE > > CHEESE_DESC= Cheese webcam support > CHEESE_LIB_DEPENDS= libcheese.so:multimedia/cheese > CHEESE_MESON_TRUE= cheese So unless you are building p11-kit or gnome-control-center with non-default options, bash-completion will be present (I was testing poudriere) and be picked up by gnome-shell. Can it hurt to always include the configuration file? We're talking less than 2 kB out of 9 MB flat size. Possibly we may need to enforce its presence. Regards, Matthias