From nobody Fri Jul 28 20:58:15 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RCKjN1phGz4p2K5 for ; Fri, 28 Jul 2023 20:58:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RCKjM5ngTz44BW for ; Fri, 28 Jul 2023 20:58:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690577895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Jmh6O0pEK2ksqWzkVSYshB4UeBEY0z+E181rwfQjp8Y=; b=vcH404TDIb6e6yFdOKdrpErm0tVmeW0hwCPKxVP6jMkXCN5kKrk8DSISYIEptqR/EpGRdI FzIw48q6qTT6jeu6WwAIRWXUoMivWSt1o+gfusthqs9/Cj5RKVzgcnYWEWLU6/km/qC8+o 2J8SD+/hCL36CymTXyrUufHTpOJ7M2DUVma1fqTuLphzo1ilbH8WEuQaXO2/KyO9puuVWl 27lY/r1x6WVDsvsKSgIKmLRw+t9UhplSMd2D3/tRyrJ0mzQ7tt6dmZ7WIETh3oKqeIFeuM bDs2T1igVpxUyygr2/82WWVRwtg4Kxfab9peHk+MxaW3+1e7bB3Xr4bBRNFYnQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690577895; a=rsa-sha256; cv=none; b=sOx+oFztrLJbVOtYNpWgsAuAFsZCRVVo6rzxBDPCYsinvIdRziw4vypsY5S7OOQYNfBzlP +uPY5tqCnudct5aWDaG+cc4ir2djZXBEcSNw/mGDActme2JKak8rBqgZGwb+zvaCfp2RNb 9iPb2ayh2JWNTXlr76nGuOUWUCj0N0zdPJaSzubRan6TWjwvPyI4h/U/1E0kCbEFxxEHxc swHy2jQS8o9Gdh9Owo94iZsaEwxi3DLLWotDZdi7A6lJcWysNvw+dytu680DKcbCucUG4I Z4lpW0XDj9jwl/cNeI2JVE6fake6xV3ml023gdSRVXUQJ/bjv3cowmCPYXYOcQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RCKjM4ZLQz1578 for ; Fri, 28 Jul 2023 20:58:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 36SKwFuq000187 for ; Fri, 28 Jul 2023 20:58:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 36SKwFl3000186 for bugs@FreeBSD.org; Fri, 28 Jul 2023 20:58:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 272783] Clean up libm use of the __ieee754_ prefix Date: Fri, 28 Jul 2023 20:58:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kargl@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272783 Bug ID: 272783 Summary: Clean up libm use of the __ieee754_ prefix Product: Base System Version: Unspecified Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: kargl@FreeBSD.org Created attachment 243675 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D243675&action= =3Dedit patch to remove __ieee754_ prefix This patch removes the __ieee754_ prefix from a number of the math functions. msun/src/math_private.h contains the statement that /* * ieee style elementary functions * * We rename functions here to improve other sources' diffability * against fdlibm. */ #define __ieee754_sqrt sqrt ... Here, fdlibm refers to https://netlib.org/fdlibm. It is seen from https://netlib.org/fdlibm/readme that this prefix was used to=20 differentiate between different standards: Wrapper functions will twist the result of the ieee754=20 function to comply to the standard specified by the value=20 of _LIB_VERSION=20 if _LIB_VERSION =3D _IEEE_, return the ieee754 result; if _LIB_VERSION =3D _SVID_, return SVID result; if _LIB_VERSION =3D _XOPEN_, return XOPEN result; if _LIB_VERSION =3D _POSIX_, return POSIX/ANSI result. (These are macros, see fdlibm.h for their definition.) AFAICT, FreeBSD has never supported these wrappers. In addition, as C99, principally the long double, functions were added to libm, this convention was not maintained. Given that only 148 of 324 files under lib/msun contain a "Copyright (C) 1993 by Sun Microsystems" statement, the removal of the __ieee754_ prefix provides consistency across all source files. The last time someone compared lib/msun to fdlibm appears to be commit 3f70824172feb82ea3dcdb3866b54fe0eb7cd890 Author: David Schultz Date: Fri Feb 4 18:26:06 2005 +0000 Reduce diffs against vendor source (Sun fdlibm 5.3). The most recent fdlibm RCS string that appears in a Sun Microsystem copyrighted file is date "95/01/18". With Oracle Corporation's acquisition of Sun Microsystems in 2009, it is unlikely that fdlibm=20 will ever be updated. A search for fdlibm at https://opensource.oracle.com/ yields no hits. Finally, OpenBSD removed the use of this prefix over 21 years ago. pSee revision 1.6 of OpenBSD's math_private.h. --=20 You are receiving this mail because: You are the assignee for the bug.=