From owner-freebsd-current Wed Nov 15 05:28:28 1995 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id FAA27545 for current-outgoing; Wed, 15 Nov 1995 05:28:28 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id FAA27540 for ; Wed, 15 Nov 1995 05:28:20 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id AAA05338; Thu, 16 Nov 1995 00:27:23 +1100 Date: Thu, 16 Nov 1995 00:27:23 +1100 From: Bruce Evans Message-Id: <199511151327.AAA05338@godzilla.zeta.org.au> To: hsu@cs.hut.fi, j@uriah.heep.sax.de Subject: Re: ISP state their FreeBSD concerns Cc: bde@zeta.org.au, current@FreeBSD.org Sender: owner-current@FreeBSD.org Precedence: bulk >> Bruce Evans writes: >> > >+ #ifndef RS_IBUFSIZE >> > > #define RS_IBUFSIZE 256 >> > >+ #endif >> > Your setup is very special. >Yes, but Bruce, why can't we insert the simple #ifndef? It doesn't >break anything, but would allow interested people (with a `very >special setup') to override it from the config file instead of hacking >the sources over and over again. Because ifdefs are evil and simply changing RS_IBUFSIZE is not sufficient. It must satisfy the following: TTYHOG - 2*RS_IBUFSIZE > 0 (much greater, < TTYHOG/2 would be silly) RS_IBUFSIZE - 11520 * (1.0/hz + max_softtty_interrupt_latency) >= 0 Bruce