From owner-cvs-src@FreeBSD.ORG Wed Jan 25 14:11:08 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A31116A424; Wed, 25 Jan 2006 14:11:07 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id B6FEB43D45; Wed, 25 Jan 2006 14:11:06 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 6938063 for multiple; Wed, 25 Jan 2006 09:09:22 -0500 Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k0PEAWhF024710; Wed, 25 Jan 2006 09:10:33 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Nate Lawson Date: Wed, 25 Jan 2006 09:11:35 -0500 User-Agent: KMail/1.9.1 References: <20060124222402.DAA4E16A463@hub.freebsd.org> <43D72B26.4000501@root.org> In-Reply-To: <43D72B26.4000501@root.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200601250911.37317.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1248/Tue Jan 24 05:54:38 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.4 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern subr_witness.c src/sys/sys ktr.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jan 2006 14:11:08 -0000 On Wednesday 25 January 2006 02:39, Nate Lawson wrote: > John Baldwin wrote: > > jhb 2006-01-24 22:23:45 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern subr_witness.c > > sys/sys ktr.h > > Log: > > - Add a new KTR_SUBSYS in place of KTR_SPARE1 to serve as a subsystem > > placeholder similar to KTR_DEV. Explain the use of KTR_DEV and > > KTR_SUBSYS in a comment as well. > > - Retire KTR_WITNESS and instead have KTR_WITNESS default to off but > > use KTR_SUBSYS if it is enabled. > > > > Revision Changes Path > > 1.212 +6 -0 src/sys/kern/subr_witness.c > > 1.36 +7 -2 src/sys/sys/ktr.h > > Thanks, and I hope as we expand, people will use KTR_SUBSYS or KTR_DEV > instead of growing their own. Well, I'll probably rework KTR as described in the arch@ thread to move away from the single runtime mask (and thus the 32-bit limit) instead giving each KTR class its own loader tunable and matching sysctl mask. There would still be a way to summarily turn KTR on and off altogether using the cpu masks, but the number of classes could grow without bound and kernel modules could even contain their own classes, etc. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org