From owner-cvs-all@FreeBSD.ORG  Fri Jul  8 21:24:36 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BD01A16A41C;
	Fri,  8 Jul 2005 21:24:36 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5386343D46;
	Fri,  8 Jul 2005 21:24:36 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.3/8.13.3) with ESMTP id j68LUiXJ039692;
	Fri, 8 Jul 2005 15:30:44 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Message-ID: <42CEEF12.4070904@samsco.org>
Date: Fri, 08 Jul 2005 15:24:34 -0600
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.7.7) Gecko/20050416
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Maxim Sobolev <sobomax@portaone.com>
References: <200507081837.j68Ib0IM082223@repoman.freebsd.org>
	<42CECCD8.5070201@portaone.com>
In-Reply-To: <42CECCD8.5070201@portaone.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.0.2
X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org
Cc: Roman Kurakin <rik@FreeBSD.org>, cvs-src@FreeBSD.org,
	src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/compat/ndis subr_ntoskrnl.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jul 2005 21:24:36 -0000

Maxim Sobolev wrote:
> Roman Kurakin wrote:
> 
>> rik         2005-07-08 18:36:59 UTC
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>     sys/compat/ndis      subr_ntoskrnl.c   Log:
>>   Use implicit type cast for ->k_lock to fix compilation of ndis
>>   as a part of the GENERIC kernel with INVARIANT* and WITNESS*
>>   turned off.
> 
> 
> I think the better fix is to change type of k_lock member from void* to 
> the struct mtx*, I've already commited such change to the RELENG_5 few 
> days ago.
> 
> -Maxim

It's a void* for portability with other OS's.  This work has already 
been ported
to Solaris, and maybe even other OS's by now.  Reducing the portability is a
bad idea, and will likely get you smacked around by Bill when he 
notices.  I'd
highly recommend not doing this again in the future.

Scott