From owner-cvs-src@FreeBSD.ORG  Thu Oct  9 13:22:15 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5BBF116A4B3; Thu,  9 Oct 2003 13:22:15 -0700 (PDT)
Received: from perrin.nxad.com (internal.nxad.com [69.1.70.251])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0C49F43FE0; Thu,  9 Oct 2003 13:22:14 -0700 (PDT)
	(envelope-from hmp@nxad.com)
Received: by perrin.nxad.com (Postfix, from userid 1072)
	id 2A0E521058; Thu,  9 Oct 2003 13:22:13 -0700 (PDT)
Date: Thu, 9 Oct 2003 13:22:13 -0700
From: Hiten Pandya <hmp@nxad.com>
To: "Jacques A. Vidrine" <nectar@FreeBSD.org>
Message-ID: <20031009202213.GA76157@perrin.nxad.com>
References: <200310090945.h999jKns055269@repoman.freebsd.org>
	<20031009121355.GD94235@madman.celabo.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20031009121355.GD94235@madman.celabo.org>
X-Operating-System: FreeBSD FreeBSD 4.7-STABLE
User-Agent: Mutt/1.5.4i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libufs bread.3 cgread.3 getino.3 libufs.3
	sbread.3 ufs_disk_close.3
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Oct 2003 20:22:15 -0000

On Thu, Oct 09, 2003 at 07:13:55AM -0500, Jacques A. Vidrine wrote:
: I think you removed the wrong header.  Is <sys/param.h> required in
: each of these cases?  If not, then I believe the synopsis should refer
: only to <sys/types.h>:
: 
:   (1) Including <sys/types.h> is (by definition) less work than
:       <sys/param.h>.

	I remove the most logical one and also, there was some
	discussion about it on IRC.  Also, I was doing an mdoc
	review of all the lib manual pages, and I thought I would fix
	this, but I did not do a deep code review to see which header
	fits best for libufs, as I did not see a reason for it.

:   (2) <sys/types.h> is a POSIX header, while <sys/param.h> is not.

	LibUFS is not a POSIX library anyway, so I don't see what this
	has got to do with anything.  If anyone is inclined on me
	backing this out, I don't mind, although, I made a
	judgement/logical call when committing this.

	Regards,

-- 
Hiten Pandya
hmp@FreeBSD.ORG, hmp@backplane.com