From owner-svn-src-all@freebsd.org Mon May 16 04:45:57 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 837CBB3C582; Mon, 16 May 2016 04:45:57 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (unknown [IPv6:2602:304:b010:ef20::f2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gw.catspoiler.org", Issuer "gw.catspoiler.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F0011A78; Mon, 16 May 2016 04:45:57 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.15.2/8.15.2) with ESMTP id u4G4jmb0069863; Sun, 15 May 2016 21:45:52 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <201605160445.u4G4jmb0069863@gw.catspoiler.org> Date: Sun, 15 May 2016 21:45:48 -0700 (PDT) From: Don Lewis Subject: Re: svn commit: r299894 - head/usr.sbin/ctld To: src-committers@freebsd.org cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org In-Reply-To: <201605160443.u4G4hlPV029103@repo.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2016 04:45:57 -0000 On 16 May, To: src-committers@freebsd.org wrote: > Author: truckman > Date: Mon May 16 04:43:47 2016 > New Revision: 299894 > URL: https://svnweb.freebsd.org/changeset/base/299894 > > Log: > pdu_delete(request) frees request, so move the call after > login_new_response(request) to avoid a use-after-free error > > Reported by: Coverity > Reviewed by: 1331219, 1331220 MFC after: 1 week