From owner-freebsd-hackers@FreeBSD.ORG Wed Oct 27 13:26:15 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DF41D106564A for ; Wed, 27 Oct 2010 13:26:14 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com [209.85.216.175]) by mx1.freebsd.org (Postfix) with ESMTP id 91F0F8FC0A for ; Wed, 27 Oct 2010 13:26:14 +0000 (UTC) Received: by qyk7 with SMTP id 7so3598743qyk.13 for ; Wed, 27 Oct 2010 06:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=UVYrvRzvJuQHYhIyQOJ742DdPARhfUZ572wQuF0VV5g=; b=Gf3+IvbpsZNVFRZXJjFDRtsCYskezzumOPKQpu75RCVmc22eU2JJwejQHbC2gT0e7K cA3h6+Lc2C3smhmdt90jmPya2XXQ7mfb41HUj/1Rc9GYuAr1WStKJ1sSs/Xi+vrjUjUg MN5U8WRGx4Na3FvRbPIJsXeQr2BjAYHRdy5cs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=vcQ7vYzN6yr88aMwodu+x/BrehX7Gk3GdZG3OwN2Vst2JGYifb8PfTIgZNpC4aazE7 0fniuNrF0AUlxjKaRX6iQl8mgaMUW2VMR9dKMDwRcOoGbBfYfLc9imro7Lz746SvvbM8 zjFFDX5/OSICHXZKi+7aXPP4/jrR3J5IP4rZ8= MIME-Version: 1.0 Received: by 10.224.54.68 with SMTP id p4mr2583675qag.312.1288185973582; Wed, 27 Oct 2010 06:26:13 -0700 (PDT) Received: by 10.229.69.135 with HTTP; Wed, 27 Oct 2010 06:26:13 -0700 (PDT) In-Reply-To: References: <1288160610.4280.18.camel@apollon> Date: Wed, 27 Oct 2010 17:26:13 +0400 Message-ID: From: Sergey Kandaurov To: FreeBSD Hackers Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PATCH] Fix 'implicit declaration' warning and update vgone(9) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2010 13:26:15 -0000 On 27 October 2010 15:33, Sergey Kandaurov wrote: > On 27 October 2010 10:23, Lars Hartmann wrote: >> The vgonel function isnt declarated in any header, the vgonel prototype >> in vgone(9) isnt correct - found by Ben Kaduk > > Hi. > > I'm afraid it's just an overlooked man page after many VFS changes in 5.x. > As vgonel() is a static (i.e. private and not visible from outside) function > IMO it should be removed from vgone(9) man page. > Something like this I'd like to check in. Comments? Index: ObsoleteFiles.inc =================================================================== --- ObsoleteFiles.inc (revision 214414) +++ ObsoleteFiles.inc (working copy) @@ -14,6 +14,8 @@ # The file is partitioned: OLD_FILES first, then OLD_LIBS and OLD_DIRS last. # +# 20101027: vgonel(9) has gone to private API a while ago +OLD_FILES+=usr/share/man/man9/vgonel.9.gz # 20101020: catch up with vm_page_sleep_if_busy rename OLD_FILES+=usr/share/man/man9/vm_page_sleep_busy.9.gz # 20101011: removed subblock.h from liblzma Index: share/man/man9/Makefile =================================================================== --- share/man/man9/Makefile (revision 214413) +++ share/man/man9/Makefile (working copy) @@ -1317,7 +1317,6 @@ vfs_getopt.9 vfs_setopt_part.9 \ vfs_getopt.9 vfs_setopts.9 MLINKS+=VFS_LOCK_GIANT.9 VFS_UNLOCK_GIANT.9 -MLINKS+=vgone.9 vgonel.9 MLINKS+=vhold.9 vdrop.9 \ vhold.9 vdropl.9 \ vhold.9 vholdl.9 Index: share/man/man9/vgone.9 =================================================================== --- share/man/man9/vgone.9 (revision 214413) +++ share/man/man9/vgone.9 (working copy) @@ -26,24 +26,21 @@ .\" .\" $FreeBSD$ .\" -.Dd November 21, 2001 +.Dd October 27, 2010 .Dt VGONE 9 .Os .Sh NAME -.Nm vgone , vgonel +.Nm vgone .Nd "prepare a vnode for reuse" .Sh SYNOPSIS .In sys/param.h .In sys/vnode.h .Ft void .Fn vgone "struct vnode *vp" -.Ft void -.Fn vgonel "struct vnode *vp" "struct thread *td" .Sh DESCRIPTION +The .Fn vgone -and -.Fn vgonel -prepare a vnode for reuse by another file system. +function prepares a vnode for reuse by another file system. The preparation includes the cleaning of all file system specific data and the removal from its mount point vnode list. .Pp @@ -55,17 +52,11 @@ as in most cases the vnode is about to be reused, or its file system is being unmounted. .Pp -The difference between +The .Fn vgone -and -.Fn vgonel -is that -.Fn vgone -locks the vnode interlock and then calls -.Fn vgonel -while -.Fn vgonel -expects the interlock to already be locked. +function takes an unlocked vnode and returns with the vnode unlocked. +.Sh SEE ALSO +.Xr vnode 9 .Sh AUTHORS This manual page was written by .An Chad David Aq davidc@acns.ab.ca . Index: share/man/man9/vflush.9 =================================================================== --- share/man/man9/vflush.9 (revision 214413) +++ share/man/man9/vflush.9 (working copy) @@ -75,7 +75,6 @@ will be returned. .Sh SEE ALSO .Xr vgone 9 , -.Xr vgonel 9 , .Xr vrele 9 .Sh AUTHORS This manual page was written by -- wbr, pluknet