From owner-freebsd-security@FreeBSD.ORG Sun Nov 16 06:20:20 2014 Return-Path: Delivered-To: freebsd-security@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3ADA4B88; Sun, 16 Nov 2014 06:20:20 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "funkthat.com", Issuer "funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 11BE4E0F; Sun, 16 Nov 2014 06:20:19 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id sAG6KJNZ008611 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 15 Nov 2014 22:20:19 -0800 (PST) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id sAG6KJHt008610; Sat, 15 Nov 2014 22:20:19 -0800 (PST) (envelope-from jmg) Date: Sat, 15 Nov 2014 22:20:18 -0800 From: John-Mark Gurney To: Adrian Chadd Subject: Re: CFR: AES-GCM and OpenCrypto work review Message-ID: <20141116062018.GH24601@funkthat.com> Mail-Followup-To: Adrian Chadd , "Andrey V. Elsukov" , freebsd-security@freebsd.org, "current@freebsd.org" References: <20141108042300.GA24601@funkthat.com> <54655257.8080705@yandex.ru> <54660389.9060409@yandex.ru> <20141114193911.GR24601@funkthat.com> <20141115024201.GW24601@funkthat.com> <546744B6.8040504@yandex.ru> <20141116061525.GG24601@funkthat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Sat, 15 Nov 2014 22:20:19 -0800 (PST) Cc: freebsd-security@freebsd.org, "Andrey V. Elsukov" , "current@freebsd.org" X-BeenThere: freebsd-security@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Security issues \[members-only posting\]" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Nov 2014 06:20:20 -0000 Adrian Chadd wrote this message on Sat, Nov 15, 2014 at 22:18 -0800: > ... no attachment? Thanks, I put it on the website since I realized it was 155k and a bit large to attach... it's at: https://www.funkthat.com/~jmg/patches/aes.ipsec.6.patch > On 15 November 2014 22:15, John-Mark Gurney wrote: > > Andrey V. Elsukov wrote this message on Sat, Nov 15, 2014 at 15:19 +0300: > >> On 15.11.2014 05:42, John-Mark Gurney wrote: > >> > I just verified that this happens on a clean HEAD @ r274534: > >> > FreeBSD 11.0-CURRENT #0 r274534: Fri Nov 14 17:17:10 PST 2014 > >> > jmg@carbon.funkthat.com:/scratch/jmg/clean/sys/amd64/compile/IPSEC amd64 > >> > > >> > No modifications, nothing, and I got the same panic: > >> > panic: System call sendto returing with kernel FPU ctx leaked > >> > cpuid = 0 > >> > KDB: stack backtrace: > >> > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe001de7a800 > >> > kdb_backtrace() at kdb_backtrace+0x39/frame 0xfffffe001de7a8b0 > >> > vpanic() at vpanic+0x189/frame 0xfffffe001de7a930 > >> > kassert_panic() at kassert_panic+0x139/frame 0xfffffe001de7a9a0 > >> > amd64_syscall() at amd64_syscall+0x616/frame 0xfffffe001de7aab0 > >> > Xfast_syscall() at Xfast_syscall+0xfb/frame 0xfffffe001de7aab0 > >> > --- syscall (64, FreeBSD ELF64, nosys), rip = 0x8011975aa, rsp = 0x7ffffffee588, rbp = 0x7ffffffee5c0 --- > >> > KDB: enter: panic > >> > > >> > So, it's clearly not my patch that is causing the issue... > >> > > >> > Andrey, can you verify that you do not receive the same panic w/o my > >> > patches? > >> > >> I tried 11.0-CURRENT r274549 with and without patches. > >> Without patches all works as expected. System encrypts and forwards > >> traffic with and without aesni module. > >> > >> With patches software rijndaelEncrypt also works. But when I load > >> aesni.ko and restart setkey -f /etc/ipsec.conf forwarding stops, errors > >> counter starts grow. And I see messages about wrong source route > >> attempts from random addresses. > > > > Ok, I was able to reproduce the bug, and found that my optimization > > for single mbuf packets was broken... I've attached a new patch > > that has the fix... > > > > This patch also has added a lock around the aesni fpu context setting > > to deal w/ the issue that I had... > > > > Let me know how things are w/ this new patch. > > > > Thanks. > > > > -- > > John-Mark Gurney Voice: +1 415 225 5579 > > > > "All that I will do, has been done, All that I have, has not." > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."