From owner-freebsd-current@FreeBSD.ORG Tue Feb 3 01:26:02 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C6740106566B for ; Tue, 3 Feb 2009 01:26:02 +0000 (UTC) (envelope-from daichi@ongs.co.jp) Received: from natial.ongs.co.jp (natial.ongs.co.jp [202.216.246.90]) by mx1.freebsd.org (Postfix) with ESMTP id 939408FC16 for ; Tue, 3 Feb 2009 01:26:02 +0000 (UTC) (envelope-from daichi@ongs.co.jp) Received: from parancell.ongs.co.jp (dullmdaler.ongs.co.jp [202.216.246.94]) by natial.ongs.co.jp (Postfix) with ESMTPSA id 5370A125422; Tue, 3 Feb 2009 10:26:01 +0900 (JST) Message-ID: <49879D28.8050100@ongs.co.jp> Date: Tue, 03 Feb 2009 10:26:00 +0900 From: Daichi GOTO User-Agent: Thunderbird 2.0.0.19 (X11/20090201) MIME-Version: 1.0 To: Ralph Zitz References: <4985FA10.5080604@imada.sdu.dk> <498607D7.7090507@videotron.ca> <20137.80.160.75.130.1233563452.squirrel@test.imada.sdu.dk> In-Reply-To: <20137.80.160.75.130.1233563452.squirrel@test.imada.sdu.dk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org Subject: Re: patch r187693 breaks HAL on amd64-current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2009 01:26:03 -0000 I have checked follow patch. After rebuild kernel with that, hald works well and issues around hald have gone away on FreeBSD 8-current/amd64. I guess recent amd64 X.Org odd issues depends on this change. ASAP quick merging is important. Thanks Ralph Zitz wrote: > Thanks! > >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Ralph Zitz wrote: >>> I'm not a HAL expert, but it seems that the patch makes HAL create a >>> zombie process when watching /dev/cd0. Reversing the patch makes HAL >>> work again. >>> >>> Link to patch message: >>> http://lists.freebsd.org/pipermail/svn-src-all/2009-January/004073.html >>> >> Hi Ralph >> >> Try the following patch, it should fix your problem with hal. >> >> Regards >> >> Steph >> -----BEGIN PGP SIGNATURE----- >> Version: GnuPG v2.0.10 (FreeBSD) >> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org >> >> iEYEARECAAYFAkmGB9YACgkQmdOXtTCX/nt8tACgj5IzDaHDEsKIJbZPefOwzkiW >> Ne4AoMV4GzfMLeVeBAWIRbmG08R7Lpj3 >> =K7Cu >> -----END PGP SIGNATURE----- >> Index: kern/sys_generic.c >> =================================================================== >> --- kern/sys_generic.c (revision 187983) >> +++ kern/sys_generic.c (working copy) >> @@ -903,7 +903,7 @@ >> * bit position in the fd_mask array. >> */ >> static __inline int >> -selflags(fd_mask **ibits, int idx, int bit) >> +selflags(fd_mask **ibits, int idx, fd_mask bit) >> { >> int flags; >> int msk; >> @@ -912,7 +912,7 @@ >> for (msk = 0; msk < 3; msk++) { >> if (ibits[msk] == NULL) >> continue; >> - if ((ibits[msk][idx] & (fd_mask)bit) == 0) >> + if ((ibits[msk][idx] & bit) == 0) >> continue; >> flags |= select_flags[msk]; >> } >> > > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" -- Daichi GOTO, http://people.freebsd.org/~daichi