From owner-cvs-sys Sat Oct 26 13:36:38 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id NAA07697 for cvs-sys-outgoing; Sat, 26 Oct 1996 13:36:38 -0700 (PDT) Received: from grumble.grondar.za (root@grumble.grondar.za [196.7.18.130]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id NAA07544; Sat, 26 Oct 1996 13:35:25 -0700 (PDT) Received: from grumble.grondar.za (mark@localhost.grondar.za [127.0.0.1]) by grumble.grondar.za (8.8.2/8.7.3) with ESMTP id WAA13468; Sat, 26 Oct 1996 22:35:19 +0200 (SAT) Message-Id: <199610262035.WAA13468@grumble.grondar.za> To: Soren Schmidt cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c Date: Sat, 26 Oct 1996 22:35:17 +0200 From: Mark Murray Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Soren Schmidt wrote: > Fixed side effects from calling add_keyboard_randomness() in the console > getc routine by not calling it. add_keyboard_randomness() currently > always reenables interrupts on 386's and 486's. This is very bad if the > console getc routine is called from the debugger and the debugger was > entered with interrupts disabled. add_keyboard_randomness() calls add_timer_randomness(), which does this: disable_intr(); outb(TIMER_MODE, TIMER_SEL0 | TIMER_LATCH); num ^= inb(TIMER_CNTR0) << 16; num ^= inb(TIMER_CNTR0) << 24; enable_intr(); If this was changed to not disable/enable the interrupts, would it cause any trouble? I don't mind getting funny numbers out of the counter, that just adds to entropy, but causing the counter device to misbehave would be a bad thing. If this was fixed, could this be added back to syscons? M -- Mark Murray 46 Harvey Rd, Claremont, Cape Town 7700, South Africa +27 21 61-3768 GMT+0200 Finger mark@grondar.za for PGP key